xiaoxiang781216 commented on code in PR #10602: URL: https://github.com/apache/nuttx/pull/10602#discussion_r1335167064
########## libs/libc/stdio/lib_fopencookie.c: ########## @@ -0,0 +1,181 @@ +/**************************************************************************** + * libs/libc/stdio/lib_fopencookie.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdio.h> +#include <stdlib.h> +#include <unistd.h> +#include <fcntl.h> +#include <string.h> +#include <assert.h> +#include <errno.h> +#include <nuttx/tls.h> + +#include "libc.h" + +/**************************************************************************** + * Private Types + ****************************************************************************/ + +static ssize_t freadcookie(FAR void *s, FAR char *buf, size_t nbytes); +static ssize_t fwritecookie(FAR void *s, FAR const char *buf, size_t nbytes); +static off_t fseekcookie(FAR void *s, off_t offset, int whence); +static int fclosecookie(FAR void *s); + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +static FAR FILE *fopencookie_init_stream(int oflags) +{ + FAR FILE *stream; + + stream = lib_zalloc(sizeof(FILE)); Review Comment: In the new design, FILE doesn't couple with fd, so fs_fdopen should change the first argument from fd to cookie. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
