wengzhe commented on code in PR #8946: URL: https://github.com/apache/nuttx/pull/8946#discussion_r1157148086
########## libs/libc/string/lib_strerror.c: ########## @@ -392,5 +399,12 @@ FAR char *strerror(int errnum) #else UNUSED(errnum); #endif - return "Unknown error"; +#ifdef CONFIG_LIBC_STRERROR_ERRNUM Review Comment: Although I let `config LIBC_STRERROR_ERRNUM`'s default be `!LIBC_STRERROR`, but I still want to keep the possibility that they're enabled together. It's very useful when `LIBC_STRERROR` is not enabled, but it can still help a little when enabled together with `LIBC_STRERROR` if unknown error really happens, so I think keep the chance might be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
