[GitHub] [nuttx] wengzhe commented on a diff in pull request #8946: libc: Print error code for unknown errors in strerror/gai_strerror

[via GitHub]

wengzhe commented on code in PR #8946:
URL: https://github.com/apache/nuttx/pull/8946#discussion_r1157141267


##########
libs/libc/netdb/lib_gaistrerror.c:
##########
@@ -105,5 +116,12 @@ FAR const char *gai_strerror(int errnum)
     }
   while (ndxlow <= ndxhi);
 #endif
-  return "Unknown error";
+#ifdef CONFIG_LIBC_GAISTRERROR_ERRNUM
+  if (snprintf(s_err, sizeof(s_err), STRERROR_UNKNOWN " %d", errnum) > 0)

Review Comment:
   Done.



##########
libs/libc/string/lib_strerror.c:
##########
@@ -392,5 +399,12 @@ FAR char *strerror(int errnum)
 #else
   UNUSED(errnum);
 #endif
-  return "Unknown error";
+#ifdef CONFIG_LIBC_STRERROR_ERRNUM
+  if (snprintf(s_err, sizeof(s_err), STRERROR_UNKNOWN " %d", errnum) > 0)

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org