xiaoxiang781216 commented on code in PR #8824:
URL: https://github.com/apache/nuttx/pull/8824#discussion_r1140992987
##########
libs/libm/Kconfig:
##########
@@ -33,6 +33,13 @@ config LIBM
comes from the Rhombus OS and was written by Nick Johnson. The
Rhombus OS math library port was contributed by Darcy Gong.
+config LIBM_NEWLIB
+ bool "Math library from Newlib"
+ depends on !ARCH_MATH_H
+ select ARCH_FLOAT_H
Review Comment:
remove select? it's better to use the toolchain provided float.h
##########
libs/libm/Makefile:
##########
@@ -23,6 +23,9 @@ include $(TOPDIR)/Make.defs
ifeq ($(CONFIG_LIBM),y)
include libm/Make.defs
endif
+ifeq ($(CONFIG_LIBM_NEWLIB),y)
Review Comment:
else ifeq
##########
tools/Directories.mk:
##########
@@ -114,6 +114,8 @@ CONTEXTDIRS += libs$(DELIM)libc
ifeq ($(CONFIG_LIBM_TOOLCHAIN)$(CONFIG_LIBM_NONE),)
CONTEXTDIRS += libs$(DELIM)libm
+else ifeq ($(CONFIG_LIBM_NEWLIB),y)
Review Comment:
remove, don't need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
