pkarashchenko commented on code in PR #8824: URL: https://github.com/apache/nuttx/pull/8824#discussion_r1136608192
########## libs/libm/newlib/Kconfig: ########## @@ -0,0 +1,17 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-language.txt in the NuttX tools repository. +# + +# These are library functions that may be overridden by architecture- +# specific implementations. Not all architectures support implementations +# for every library function. + +# Default settings for C library functions that may be replaced with +# architecture-specific versions. + +config LIBM_NEWLIB_HWFP Review Comment: Why do we need to be able to configure it differently than other part of the system? I mean if a hard float is selected for MCU configuration the what is the use case for switching newlib to soft float? ########## libs/libm/newlib/include/_newlib_version.h: ########## @@ -0,0 +1,33 @@ +/**************************************************************************** + * libs/libm/newlib/include/_newlib_version.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef _NEWLIB_VERSION_H__ +#define _NEWLIB_VERSION_H__ 1 Review Comment: ```suggestion #ifndef __LIBS_LIBM_NEWLIB_INCLUDE__NEWLIB_VERSION_H #define __LIBS_LIBM_NEWLIB_INCLUDE__NEWLIB_VERSION_H ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
