qinwei2004 commented on code in PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#discussion_r1135480805


##########
arch/arm64/src/fvp-v8r/fvp_lowputc.S:
##########
@@ -50,24 +50,6 @@
  * Public Functions
  ****************************************************************************/
 
-/* PL011 UART initialization
- * xb: register which contains the UART base address
- * c: scratch register number
- */
-
-GTEXT(up_earlyserialinit)
-SECTION_FUNC(text, up_earlyserialinit)

Review Comment:
   @acassis @jerpelea @pkarashchenko 
   it need to do early initialize when we want to print something in 
arm64_head.S
   I cannot call arm64_earlyserialinit or other C function because it's very 
early (before BSS initialize)
   and with a high ELs
   At next patch, I will add arm64_earlyprintinit which is only initialize 
serial just setting BAUDRATE to bring serial into base work state in assembly 
language. A complete initiation will be done at arm64_earlyserialinit
   
   I consider someone can also logging the booting message through rewriting 
arm64_lowputc with other debug method (eg semihosting, ARM debug channel etc), 
not only serial
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to