pkarashchenko commented on code in PR #8779:
URL: https://github.com/apache/nuttx/pull/8779#discussion_r1133767720
##########
arch/arm64/src/fvp-v8r/fvp_lowputc.S:
##########
@@ -50,24 +50,6 @@
* Public Functions
****************************************************************************/
-/* PL011 UART initialization
- * xb: register which contains the UART base address
- * c: scratch register number
- */
-
-GTEXT(up_earlyserialinit)
-SECTION_FUNC(text, up_earlyserialinit)
Review Comment:
I see many mess in the code like in `arm_nommuhead.S` that calls
`showprogress` -> `arm_lowputc` before
```
#ifdef USE_EARLYSERIALINIT
bl arm_earlyserialinit
#endif
```
And that is fine if underlying BL did all the work to mux the pins and setup
the UART registers, but most probably will be unless in other case.
Some of the MCUs have `xxx_lowsetup()` that is similar to what
`up_earlyserialinit` is doing here.
I think that we should hold off a bit here as this is not just removing of
something unused and re-inspect how the things should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
