xiaoxiang781216 commented on code in PR #1440:
URL: https://github.com/apache/nuttx-apps/pull/1440#discussion_r1036087441
##########
system/nxplayer/nxplayer.c:
##########
@@ -80,6 +80,12 @@ struct nxplayer_ext_fmt_s
};
#endif
+struct nxplayer_fmt_s
Review Comment:
merge with nxplayer_dec_ops_s?
##########
include/system/nxplayer.h:
##########
@@ -39,6 +39,14 @@
* Public Type Declarations
****************************************************************************/
+struct nxplayer_dec_ops_s
+{
+ int format;
+ int (*pre_parse)(int fd, uint32_t *samplerate,
+ uint8_t *chans, uint8_t *bps);
Review Comment:
but not add all
##########
system/nxplayer/Makefile:
##########
@@ -23,6 +23,8 @@ include $(APPDIR)/Make.defs
# NxPlayer Library
CSRCS = nxplayer.c
+CSRCS += nxplayer_offload_mp3.c
+CSRCS += nxplayer_pcm.c
Review Comment:
let's unify the name either nxplayer_[mp3|pcm].c or
nxplayer_offload_[mp3|pcm].c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
