pkarashchenko commented on code in PR #5070:
URL: https://github.com/apache/incubator-nuttx/pull/5070#discussion_r999580260
##########
include/nuttx/mutex.h:
##########
@@ -98,6 +98,7 @@ static inline int nxmutex_init(FAR mutex_t *mutex)
return _SEM_ERRVAL(ret);
}
+ _SEM_SETPROTOCOL(mutex, PRIOINHERIT_FLAGS_ENABLE);
Review Comment:
```suggestion
_SEM_SETPROTOCOL(mutex, SEM_PRIO_INHERIT);
```
##########
arch/arm/src/kinetis/kinetis_i2c.c:
##########
@@ -191,7 +191,7 @@ static struct kinetis_i2cdev_s g_i2c0_dev =
.config = &kinetis_i2c0_config,
.refs = 0,
.lock = NXMUTEX_INITIALIZER,
- .wait = NXSEM_INITIALIZER(0, PRIOINHERIT_FLAGS_DISABLE),
+ .wait = SEM_INITIALIZER(0),
Review Comment:
I still think that we need to use `NXSEM_INITIALIZER(0, 0)` for kernel code,
just from style point of view, but I will not block PR because of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
