[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7114: Add CodeChecker to CI

[GitBox]

xiaoxiang781216 commented on code in PR #7114:
URL: https://github.com/apache/incubator-nuttx/pull/7114#discussion_r990776970


##########
.github/workflows/build.yml:
##########
@@ -157,17 +158,35 @@ jobs:
             export CCACHE_DIR=`pwd`/ccache
             mkdir $CCACHE_DIR
             export ARTIFACTDIR=`pwd`/buildartifacts
+            export CODECHECKERLOGSDIR=`pwd`/codecheckerlogs

Review Comment:
   let's reuse ARTIFACTDIR to save the codechecker output



##########
tools/testbuild.sh:
##########
@@ -57,7 +62,7 @@ esac
 
 function showusage {
   echo ""
-  echo "USAGE: $progname [-l|m|c|g|n] [-d] [-e <extraflags>] [-x] [-j <ncpus>] 
[-a <appsdir>] [-t <topdir>] [-p] [-G] <testlist-file>"
+  echo "USAGE: $progname [-l|m|c|g|n] [-d] [-e <extraflags>] [-x] [-j <ncpus>] 
[-a <appsdir>] [-t <topdir>] [-p] [-G] [--codechecker] [--codechecker-failed] 
<testlist-file>"

Review Comment:
   remove  [--codechecker-failed]



##########
.github/workflows/build.yml:
##########
@@ -157,17 +158,35 @@ jobs:
             export CCACHE_DIR=`pwd`/ccache
             mkdir $CCACHE_DIR
             export ARTIFACTDIR=`pwd`/buildartifacts
+            export CODECHECKERLOGSDIR=`pwd`/codecheckerlogs
+            export BOARDSEL=${{matrix.boards}}

Review Comment:
   don't need temp variable



##########
tools/testbuild.sh:
##########
@@ -208,13 +221,63 @@ function exportandimport {
   return $fail
 }
 
+function compressartifacts {
+  local target_path=$1
+  local target_name=$2
+
+  pushd $target_path >/dev/null
+
+  tar zcf ${target_name}.tar.gz ${target_name}
+  rm -rf ${target_name} 
+
+  popd >/dev/null
+}
+
 function makefunc {

Review Comment:
   let's add checkfunc and call it from build function



##########
.github/workflows/build.yml:
##########
@@ -157,17 +158,35 @@ jobs:
             export CCACHE_DIR=`pwd`/ccache
             mkdir $CCACHE_DIR
             export ARTIFACTDIR=`pwd`/buildartifacts
+            export CODECHECKERLOGSDIR=`pwd`/codecheckerlogs
+            export BOARDSEL=${{matrix.boards}}
             git config --global --add safe.directory 
/github/workspace/sources/nuttx
             git config --global --add safe.directory 
/github/workspace/sources/apps
             cd sources/nuttx/tools/ci
-            ./cibuild.sh -A -R -c testlist/${{matrix.boards}}.dat
+            if [ "X${BOARDSEL}" = "Xcodechecker" ]; then
+              if ${{ env.CODECHECKER_FAIL }}; then
+                ./cibuild.sh -A -R -c --codechecker --codechecker-failed 
testlist/${BOARDSEL}.dat
+              else
+                ./cibuild.sh -A -R -c --codechecker testlist/${BOARDSEL}.dat
+              fi
+            else
+              ./cibuild.sh -A -R -c testlist/${BOARDSEL}.dat
+            fi
             ccache -s
 
       - uses: actions/upload-artifact@v3
         with:
           name: linux-builds
           path: buildartifacts/
         continue-on-error: true
+      
+      - name: Upload CodeChecker Logs 

Review Comment:
   let's reuse buildartifacts



##########
tools/testbuild.sh:
##########
@@ -392,7 +454,6 @@ function dotest {
 }
 
 # Perform the build test for each entry in the test list file
-

Review Comment:
   revert



##########
tools/testbuild.sh:
##########
@@ -336,7 +399,6 @@ function dotest {
   echo 
"===================================================================================="
   config=`echo $1 | cut -d',' -f1`
   check=${HOST},${config/\//:}
-

Review Comment:
   revert



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org