gustavonihei commented on code in PR #6920:
URL: https://github.com/apache/incubator-nuttx/pull/6920#discussion_r983504059


##########
crypto/Kconfig:
##########
@@ -39,6 +39,11 @@ config CRYPTO_CRYPTODEV
        bool "cryptodev support"
        default n
 
+config CRYPTO_CRYPTODEV_HARDWARE
+       bool "cryptodev hardware support"
+       depends on CRYPTO_CRYPTODEV
+       default n
+
 config CRYPTO_SW_AES

Review Comment:
   `CRYPTO_SW_AES`  only use is being removed in this PR, so this config should 
be either removed or reworked.
   
   I believe it should be renamed to something like `CRYPTO_SW_IMPL` to 
consider the newly supported algorithms. Besides, the `depends on 
ALLOW_BSD_COMPONENTS` is still valid for AES and the others, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to