gustavonihei commented on code in PR #6920:
URL: https://github.com/apache/incubator-nuttx/pull/6920#discussion_r982392168
##########
arch/risc-v/src/esp32c3/esp32c3_sha.c:
##########
@@ -668,6 +668,7 @@ void esp32c3_sha1_free(struct esp32c3_sha1_context_s *ctx)
void esp32c3_sha256_init(struct esp32c3_sha256_context_s *ctx)
{
memset(ctx, 0, sizeof(struct esp32c3_sha256_context_s));
+ ctx->mode = ESP32C3_SHA2_256;
Review Comment:
The mode configuration is currently being performed in
`esp32c3_sha256_starts`, is it really required to set a default value here?
What may be missing is to add this function (and `esp32c3_sha1_starts`) to
the driver interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
