[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7131: poll: add poll_notify() api and call it in all drivers.

[GitBox]

xiaoxiang781216 commented on code in PR #7131:
URL: https://github.com/apache/incubator-nuttx/pull/7131#discussion_r977752212


##########
drivers/input/cypress_mbr3108.c:
##########
@@ -983,21 +983,8 @@ static int mbr3108_close(FAR struct file *filep)
 
 static void mbr3108_poll_notify(FAR struct mbr3108_dev_s *priv)

Review Comment:
   remove?



##########
net/local/local_netpoll.c:
##########
@@ -215,12 +192,12 @@ int local_pollsetup(FAR struct socket *psock, FAR struct 
pollfd *fds)
                 }
             }
 
+          shadowfds[0]        = *fds;
           shadowfds[0].fd     = 1; /* Does not matter */
-          shadowfds[0].sem    = fds->sem;
           shadowfds[0].events = fds->events & ~POLLOUT;

Review Comment:
   shadowfds[0].events &= ~POLLOUT;



##########
net/local/local_netpoll.c:
##########
@@ -215,12 +192,12 @@ int local_pollsetup(FAR struct socket *psock, FAR struct 
pollfd *fds)
                 }
             }
 
+          shadowfds[0]        = *fds;
           shadowfds[0].fd     = 1; /* Does not matter */
-          shadowfds[0].sem    = fds->sem;
           shadowfds[0].events = fds->events & ~POLLOUT;
 
+          shadowfds[1]        = *fds;
           shadowfds[1].fd     = 0; /* Does not matter */
-          shadowfds[1].sem    = fds->sem;
           shadowfds[1].events = fds->events & ~POLLIN;

Review Comment:
   shadowfds[0].events &= ~POLLIN;



##########
drivers/usbhost/usbhost_xboxcontroller.c:
##########
@@ -561,8 +561,6 @@ static void usbhost_destroy(FAR void *arg)
 
 static void usbhost_pollnotify(FAR struct usbhost_state_s *priv)
 {
-  int i;

Review Comment:
   Ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org