[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7131: poll: add poll_notify() api and call it in all drivers.

[GitBox]

pkarashchenko commented on code in PR #7131:
URL: https://github.com/apache/incubator-nuttx/pull/7131#discussion_r976117835


##########
net/netlink/netlink_sockif.c:
##########
@@ -595,7 +593,7 @@ static int netlink_poll(FAR struct socket *psock, FAR 
struct pollfd *fds,
       if (revents != 0)
         {
           fds->revents = revents;
-          nxsem_post(fds->sem);
+          poll_notify_nocheck(&fds, 1, 0);

Review Comment:
   What about this place. It seems to be different from other similar places



##########
net/netlink/netlink_sockif.c:
##########
@@ -595,7 +593,7 @@ static int netlink_poll(FAR struct socket *psock, FAR 
struct pollfd *fds,
       if (revents != 0)
         {
           fds->revents = revents;
-          nxsem_post(fds->sem);
+          poll_notify_nocheck(&fds, 1, 0);

Review Comment:
   What about this place? It seems to be different from other similar places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org