[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7126: watchdog: Support auto monitor keep alive from timer/oneshot lowerhalf

[GitBox]

xiaoxiang781216 commented on code in PR #7126:
URL: https://github.com/apache/incubator-nuttx/pull/7126#discussion_r974162758


##########
drivers/timers/Kconfig:
##########
@@ -366,13 +366,21 @@ if WATCHDOG_AUTOMONITOR
 
 choice
        prompt "Auto-monitor keepalive by"
-       default WATCHDOG_AUTOMONITOR_BY_TIMER
+       default WATCHDOG_AUTOMONITOR_BY_WDOG
 
 config WATCHDOG_AUTOMONITOR_BY_CAPTURE
        bool "Capture callback"
 
+config WATCHDOG_AUTOMONITOR_BY_ONESHOT
+       bool "Oneshot callback"
+       depends on ONESHOT
+
 config WATCHDOG_AUTOMONITOR_BY_TIMER
        bool "Timer callback"
+       depends on TIMER
+
+config WATCHDOG_AUTOMONITOR_BY_WDOG
+       bool "Wdog callback"

Review Comment:
   Done



##########
drivers/timers/Kconfig:
##########
@@ -366,13 +366,21 @@ if WATCHDOG_AUTOMONITOR
 
 choice
        prompt "Auto-monitor keepalive by"
-       default WATCHDOG_AUTOMONITOR_BY_TIMER
+       default WATCHDOG_AUTOMONITOR_BY_WDOG
 
 config WATCHDOG_AUTOMONITOR_BY_CAPTURE
        bool "Capture callback"
 
+config WATCHDOG_AUTOMONITOR_BY_ONESHOT
+       bool "Oneshot callback"
+       depends on ONESHOT
+
 config WATCHDOG_AUTOMONITOR_BY_TIMER
        bool "Timer callback"
+       depends on TIMER
+
+config WATCHDOG_AUTOMONITOR_BY_WDOG
+       bool "Wdog callback"
 
 config WATCHDOG_AUTOMONITOR_BY_WORKER
        bool "Worker callback"

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org