acassis commented on code in PR #7126:
URL: https://github.com/apache/incubator-nuttx/pull/7126#discussion_r974109681
##########
drivers/timers/Kconfig:
##########
@@ -366,13 +366,21 @@ if WATCHDOG_AUTOMONITOR
choice
prompt "Auto-monitor keepalive by"
- default WATCHDOG_AUTOMONITOR_BY_TIMER
+ default WATCHDOG_AUTOMONITOR_BY_WDOG
config WATCHDOG_AUTOMONITOR_BY_CAPTURE
bool "Capture callback"
+config WATCHDOG_AUTOMONITOR_BY_ONESHOT
+ bool "Oneshot callback"
+ depends on ONESHOT
+
Review Comment:
Please include a Help description about this symbol, when know what an
Oneshot callback is, but a newcomer user could have no clue.
##########
drivers/timers/Kconfig:
##########
@@ -366,13 +366,21 @@ if WATCHDOG_AUTOMONITOR
choice
prompt "Auto-monitor keepalive by"
- default WATCHDOG_AUTOMONITOR_BY_TIMER
+ default WATCHDOG_AUTOMONITOR_BY_WDOG
config WATCHDOG_AUTOMONITOR_BY_CAPTURE
bool "Capture callback"
Review Comment:
Please include a Help description about this symbol, a newcomer user could
become confused about it.
##########
drivers/timers/Kconfig:
##########
@@ -366,13 +366,21 @@ if WATCHDOG_AUTOMONITOR
choice
prompt "Auto-monitor keepalive by"
- default WATCHDOG_AUTOMONITOR_BY_TIMER
+ default WATCHDOG_AUTOMONITOR_BY_WDOG
config WATCHDOG_AUTOMONITOR_BY_CAPTURE
bool "Capture callback"
+config WATCHDOG_AUTOMONITOR_BY_ONESHOT
+ bool "Oneshot callback"
+ depends on ONESHOT
+
config WATCHDOG_AUTOMONITOR_BY_TIMER
bool "Timer callback"
+ depends on TIMER
+
+config WATCHDOG_AUTOMONITOR_BY_WDOG
+ bool "Wdog callback"
config WATCHDOG_AUTOMONITOR_BY_WORKER
bool "Worker callback"
Review Comment:
And also to Idle callback, we need to improve our documentation and have
more info on Kconfig makes user's life better
##########
drivers/timers/Kconfig:
##########
@@ -366,13 +366,21 @@ if WATCHDOG_AUTOMONITOR
choice
prompt "Auto-monitor keepalive by"
- default WATCHDOG_AUTOMONITOR_BY_TIMER
+ default WATCHDOG_AUTOMONITOR_BY_WDOG
config WATCHDOG_AUTOMONITOR_BY_CAPTURE
bool "Capture callback"
+config WATCHDOG_AUTOMONITOR_BY_ONESHOT
+ bool "Oneshot callback"
+ depends on ONESHOT
+
config WATCHDOG_AUTOMONITOR_BY_TIMER
bool "Timer callback"
+ depends on TIMER
Review Comment:
Ditto, also it could be useful to give some hints what/how he will configue
the timer later
##########
drivers/timers/Kconfig:
##########
@@ -366,13 +366,21 @@ if WATCHDOG_AUTOMONITOR
choice
prompt "Auto-monitor keepalive by"
- default WATCHDOG_AUTOMONITOR_BY_TIMER
+ default WATCHDOG_AUTOMONITOR_BY_WDOG
config WATCHDOG_AUTOMONITOR_BY_CAPTURE
bool "Capture callback"
+config WATCHDOG_AUTOMONITOR_BY_ONESHOT
+ bool "Oneshot callback"
+ depends on ONESHOT
+
config WATCHDOG_AUTOMONITOR_BY_TIMER
bool "Timer callback"
+ depends on TIMER
+
+config WATCHDOG_AUTOMONITOR_BY_WDOG
+ bool "Wdog callback"
Review Comment:
Ditto
##########
drivers/timers/Kconfig:
##########
@@ -366,13 +366,21 @@ if WATCHDOG_AUTOMONITOR
choice
prompt "Auto-monitor keepalive by"
- default WATCHDOG_AUTOMONITOR_BY_TIMER
+ default WATCHDOG_AUTOMONITOR_BY_WDOG
config WATCHDOG_AUTOMONITOR_BY_CAPTURE
bool "Capture callback"
+config WATCHDOG_AUTOMONITOR_BY_ONESHOT
+ bool "Oneshot callback"
+ depends on ONESHOT
+
config WATCHDOG_AUTOMONITOR_BY_TIMER
bool "Timer callback"
+ depends on TIMER
+
+config WATCHDOG_AUTOMONITOR_BY_WDOG
+ bool "Wdog callback"
config WATCHDOG_AUTOMONITOR_BY_WORKER
bool "Worker callback"
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
