pkarashchenko commented on code in PR #7018:
URL: https://github.com/apache/incubator-nuttx/pull/7018#discussion_r965190923
##########
sched/wqueue/kwork_thread.c:
##########
@@ -169,19 +168,20 @@ static int work_thread(int argc, FAR char *argv[])
/* Mark the work as no longer being queued */
work->worker = NULL;
+ leave_critical_section(flags);
/* Do the work. Re-enable interrupts while the work is being
* performed... we don't have any idea how long this will take!
*/
- leave_critical_section(flags);
CALL_WORKER(worker, arg);
- flags = enter_critical_section();
+ }
+ else
+ {
+ leave_critical_section(flags);
Review Comment:
Again, I do not see any issue with the current approach. The existing code
ensures that all code except `CALL_WORKER(worker, arg);` is executed inside the
critical section, It is straight forward and easy to understand at least to me.
I will let other reviewers to write their opinion on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
