GUIDINGLI opened a new pull request, #7018:
URL: https://github.com/apache/incubator-nuttx/pull/7018

   ## Summary
   wqueue: change single queue to double queue to improve speed
   wqueue: fix work_qcancel() judge error caused by the union in struct work_s
   
       in struct work_s:
       union
       {
         struct
         {
           struct sq_entry_s sq; /* Implements a single linked list */
           clock_t qtime;        /* Time work queued */
         } s;
         struct wdog_s timer;    /* Delay expiry timer */
       }
       
       while we use WDOG_ISACTIVE(&work->timer) to decide use sq or timer,
       that is error, wd_cancel() maybe modify this area, sq_rem() also can
       modify this area.
       So we can't use the WDOG_ISACTIVE(&work->timer) to take as the judgement,
       when there is a union.
       
       Fix:
       remove the union
   
   
   ## Impact
   
   wqueue
   
   ## Testing
   
   vela
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to