xiaoxiang781216 commented on code in PR #6845: URL: https://github.com/apache/incubator-nuttx/pull/6845#discussion_r945283988
########## drivers/wireless/ieee80211/bcm43xxx/bcmf_gpio.c: ########## @@ -0,0 +1,103 @@ +/**************************************************************************** + * drivers/wireless/ieee80211/bcm43xxx/bcmf_gpio.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <stdbool.h> +#include <errno.h> +#include <stdio.h> + +#include <nuttx/wireless/ieee80211/bcmf_gpio.h> + +#include "bcmf_cdc.h" +#include "bcmf_interface.h" +#include "../../../../net/netdev/netdev.h" + +/**************************************************************************** + * Private Type Definitions + ****************************************************************************/ + +typedef struct bcmf_dev_s bcmf_dev_t; + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: bcmf_set_gpio + ****************************************************************************/ + +int bcmf_set_gpio(FAR const char *ifname, int pin, bool value) Review Comment: why not use bcmf_dev_s as the first argument ########## drivers/wireless/ieee80211/bcm43xxx/bcmf_chip_data.h: ########## @@ -0,0 +1,68 @@ +/**************************************************************************** + * drivers/wireless/ieee80211/bcm43xxx/bcmf_chip_data.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __DRIVERS_WIRELESS_IEEE80211_BCM43XXX_BCMF_CHIP_H Review Comment: ```suggestion #ifndef __DRIVERS_WIRELESS_IEEE80211_BCM43XXX_BCMF_CHIP_DATA_H ``` ########## drivers/wireless/ieee80211/bcm43xxx/bcmf_chip_data.h: ########## @@ -0,0 +1,68 @@ +/**************************************************************************** + * drivers/wireless/ieee80211/bcm43xxx/bcmf_chip_data.h + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __DRIVERS_WIRELESS_IEEE80211_BCM43XXX_BCMF_CHIP_H +#define __DRIVERS_WIRELESS_IEEE80211_BCM43XXX_BCMF_CHIP_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <stdint.h> +#include <stdbool.h> + +#include <nuttx/list.h> +#include <nuttx/semaphore.h> +#include <nuttx/wireless/ieee80211/bcmf_gspi.h> + +#include "bcmf_driver.h" +#include "bcmf_sdio_core.h" + +/**************************************************************************** + * Public Types + ****************************************************************************/ + +/* SDIO chip configuration structure */ + +struct bcmf_chip_data +{ + uint32_t ram_base; + uint32_t ram_size; + uint32_t core_base[MAX_CORE_ID]; + + /* In-memory file images */ + + FAR uint8_t *nvram_image; + FAR unsigned int *nvram_image_size; + +#ifndef CONFIG_IEEE80211_BROADCOM_FWFILES + FAR uint8_t *firmware_image; + FAR unsigned int *firmware_image_size; + +#ifdef CONFIG_IEEE80211_BROADCOM_HAVE_CLM + FAR uint8_t *clm_blob_image; + FAR unsigned int *clm_blob_image_size; +#endif +#endif +}; + +#endif Review Comment: add new line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
