pkarashchenko commented on code in PR #6618:
URL: https://github.com/apache/incubator-nuttx/pull/6618#discussion_r922677247
##########
arch/arm/src/common/arm_semi_syslog.c:
##########
@@ -54,15 +52,25 @@ int up_putc(int ch)
}
/****************************************************************************
- * Name: up_puts
+ * Name: up_nputs
*
* Description:
* Output a string on the console
*
****************************************************************************/
-void up_puts(const char *str)
+void up_nputs(const char *str, size_t len)
{
- smh_call(SEMI_SYSLOG_WRITE0, (char *)str);
+ if (len == ~((size_t)0))
+ {
+ smh_call(SEMI_SYSLOG_WRITE0, (char *)str);
Review Comment:
I see... Only `~0` is for WRITE0 call and means that string is
null-terminated.
So indeed, my previous comment about `*str` check in else was wrong. In the
else case we know the exact length, so `*str` can be omitted.
Let's move to the previous variant and remove redundant check in the else
case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
