xiaoxiang781216 commented on code in PR #6618:
URL: https://github.com/apache/incubator-nuttx/pull/6618#discussion_r922207174
##########
drivers/syslog/syslog_channel.c:
##########
@@ -217,16 +217,7 @@ static ssize_t syslog_default_write(FAR struct
syslog_channel_s *channel,
FAR const char *buffer, size_t buflen)
{
#if defined(CONFIG_ARCH_LOWPUTC)
- static sem_t sem = SEM_INITIALIZER(1);
- size_t nwritten;
-
- nxsem_wait(&sem);
Review Comment:
We found that calling syslog inside signal handler may happen the dead lock,
so it look better to let up_nputs decide how to protect the concurrent access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
