xiaoxiang781216 commented on code in PR #6605: URL: https://github.com/apache/incubator-nuttx/pull/6605#discussion_r921379827
########## fs/mount/fs_procfs_mount.c: ########## @@ -257,11 +261,19 @@ static int blocks_entry(FAR const char *mountpoint, /* Generate blocks list one line at a time */ +#ifdef CONFIG_LIBC_LONG_LONG Review Comment: don't need change with https://github.com/apache/incubator-nuttx/pull/6613 ########## fs/mount/fs_procfs_mount.c: ########## @@ -101,6 +101,7 @@ struct mount_info_s /* Helpers */ +printflike(2, 3) Review Comment: But it isn't good to leave the temporary change in git history. ########## fs/mount/fs_procfs_mount.c: ########## @@ -248,6 +248,10 @@ static int blocks_entry(FAR const char *mountpoint, if (!info->header) { +#if defined(CONFIG_HAVE_LONG_LONG) && !defined(CONFIG_LIBC_LONG_LONG) + finfo("long long is enabled, but libc does not support it;\n" Review Comment: it's strange to print log here, or you can use static_assert instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
