ALTracer commented on code in PR #6605: URL: https://github.com/apache/incubator-nuttx/pull/6605#discussion_r920977116
########## fs/mount/fs_procfs_mount.c: ########## @@ -248,6 +248,10 @@ static int blocks_entry(FAR const char *mountpoint, if (!info->header) { +#if defined(CONFIG_HAVE_LONG_LONG) && !defined(CONFIG_LIBC_LONG_LONG) Review Comment: Not really. I would like 32-bit devices to still calculate with ull but print via ul, because some devices are (implied to be) unlikely to have to deal with large filesystems and block counts. They don't *require* LIBC_LONG_LONG in principle, no matter the code size increase (and how we measure it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org