ALTracer commented on PR #6606: URL: https://github.com/apache/incubator-nuttx/pull/6606#issuecomment-1183580273
I have a problem with this PR. 1. It contradicts a key philosophy of NuttX being small/lightweight and configurable. 2. It binds LIBC_LONG_LONG and HAVE_LONG_LONG together, but these options existed separately for a reason. 3. Forced code size increase of ~600* bytes, even though most printf invocations don't require ull handling. 4. No obvious way to disable HAVE_LONG_LONG (located solely in https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/compiler.h#L248) My original PR #6605 aimed at a different problem and fixed it precisely. I never asked for system-wide breaking changes. *TBD, see my later comments in #5253 I would like you to provide a way for users to either disable HAVE_LONG_LONG via Kconfig, or to introduce a separate option to forbid using long long division systemwide as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
