adamkaliszan commented on code in PR #6511:
URL: https://github.com/apache/incubator-nuttx/pull/6511#discussion_r908321093
##########
boards/xtensa/esp32/common/src/esp32_ssd1680.c:
##########
@@ -35,116 +35,134 @@
# include <nuttx/video/fb.h>
#endif
+#include "arch/board/board.h"
#include "esp32_gpio.h"
#include "esp32_spi.h"
#ifdef CONFIG_LCD_SSD1680
/****************************************************************************
- * Private Functions
+ * Private Functions Prototypes
****************************************************************************/
-#if defined(CONFIG_SSD1680_GPIO_PIN_PWR) && (CONFIG_SSD1680_GPIO_PIN_PWR>=0)
-static bool ssd1680_set_vcc(bool state)
-{
- esp32_gpiowrite(CONFIG_SSD1680_GPIO_PIN_PWR, state);
- return true;
-}
+#ifdef DISPLAY_VCC
+static bool ssd1680_set_vcc(bool state);
#endif
-#if defined(CONFIG_SSD1680_GPIO_PIN_RST) && (CONFIG_SSD1680_GPIO_PIN_RST>=0)
-static bool ssd1680_set_rst(bool state)
-{
- esp32_gpiowrite(CONFIG_SSD1680_GPIO_PIN_RST, state);
- return true;
-}
+#ifdef DISPLAY_RST
+static bool ssd1680_set_rst(bool state);
#endif
-#if defined(CONFIG_SSD1680_GPIO_PIN_BUSY) && (CONFIG_SSD1680_GPIO_PIN_BUSY>=0)
-static bool ssd1680_check_busy(void)
-{
- return esp32_gpioread(CONFIG_SSD1680_GPIO_PIN_BUSY);
-}
+#ifdef DISPLAY_BUSY
+static bool ssd1680_check_busy(void);
#endif
/****************************************************************************
* Private Data
****************************************************************************/
static struct lcd_dev_s *g_lcddev;
+
struct ssd1680_priv_s g_ssd1680_priv =
Review Comment:
OK it is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
