slorquet commented on PR #6287: URL: https://github.com/apache/incubator-nuttx/pull/6287#issuecomment-1129867992
When the CI first failed, I was surprised to encounter an attempt to set the HSI divider in a board that did not use HSI. I investigated and found that code in the rcc_reset() function, which was surprising https://github.com/apache/incubator-nuttx/blob/4f31c89963ebdf51a41705c508de8d0891fbaca3/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c#L149 That is why I moved the code into stm32_clockconfig() where the HSI configuration is applied: https://github.com/apache/incubator-nuttx/blob/4f31c89963ebdf51a41705c508de8d0891fbaca3/arch/arm/src/stm32h7/stm32h7x3xx_rcc.c#L599 The STM32 chips boot with a default clock that just works, so there is no need to set a HSI divider in the rcc_reset code. Since my board works like this (a breakage would hang) I am confident that my change is correct. Thats just my opinion and I agree that someone could add more info here if you dont have enough trust in my change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
