pkarashchenko commented on code in PR #6092:
URL: https://github.com/apache/incubator-nuttx/pull/6092#discussion_r862893524
##########
arch/arm/src/tiva/common/tiva_can.c:
##########
@@ -2157,9 +2157,9 @@ static void tivacan_disable_mbox(FAR struct can_dev_s
*dev,
* Return value: 0 on success, a negated errno on failure.
****************************************************************************/
-static int tivacan_initfilter(FAR struct can_dev_s *dev,
- FAR tiva_can_fifo_t *fifo,
- FAR void *filter,
+static int tivacan_initfilter(struct can_dev_s *dev,
+ tiva_can_fifo_t *fifo,
+ void *filter,
int type)
Review Comment:
```suggestion
int type)
```
##########
boards/arm/stm32/clicker2-stm32/src/stm32_automount.c:
##########
@@ -148,15 +148,15 @@ static const struct stm32_automount_config_s
g_mb2_mmcsdconfig =
*
****************************************************************************/
-static int stm32_attach(FAR const struct automount_lower_s *lower,
- automount_handler_t isr, FAR void *arg)
+static int stm32_attach(const struct automount_lower_s *lower,
+ automount_handler_t isr, void *arg)
Review Comment:
```suggestion
static int stm32_attach(const struct automount_lower_s *lower,
automount_handler_t isr, void *arg)
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -2930,7 +2930,7 @@ static void stm32serial_pmnotify(FAR struct pm_callback_s
*cb, int domain,
****************************************************************************/
#ifdef CONFIG_PM
-static int stm32serial_pmprepare(FAR struct pm_callback_s *cb, int domain,
+static int stm32serial_pmprepare(struct pm_callback_s *cb, int domain,
enum pm_state_e pmstate)
Review Comment:
```suggestion
static int stm32serial_pmprepare(struct pm_callback_s *cb, int domain,
enum pm_state_e pmstate)
```
##########
boards/arm/cxd56xx/drivers/sensors/bmp280_scu.c:
##########
@@ -962,14 +962,14 @@ int bmp280press_register(FAR const char *devpath, int
minor,
*
****************************************************************************/
-int bmp280temp_register(FAR const char *devpath, int minor,
- FAR struct i2c_master_s *i2c, int port)
+int bmp280temp_register(const char *devpath, int minor,
+ struct i2c_master_s *i2c, int port)
Review Comment:
```suggestion
int bmp280temp_register(const char *devpath, int minor,
struct i2c_master_s *i2c, int port)
```
##########
boards/arm/cxd56xx/drivers/sensors/bmp280_scu.c:
##########
@@ -128,39 +128,39 @@
struct bmp280_dev_s
{
- FAR struct i2c_master_s *i2c; /* I2C interface */
- uint8_t addr; /* BMP280 I2C address */
- int freq; /* BMP280 Frequency <= 3.4MHz */
- int port; /* I2C port */
- struct seq_s *seq; /* Sequencer */
- int id; /* Sequencer id */
+ struct i2c_master_s *i2c; /* I2C interface */
+ uint8_t addr; /* BMP280 I2C address */
+ int freq; /* BMP280 Frequency <= 3.4MHz */
+ int port; /* I2C port */
+ struct seq_s *seq; /* Sequencer */
+ int id; /* Sequencer id */
};
/****************************************************************************
* Private Function Prototypes
****************************************************************************/
-static uint8_t bmp280_getreg8(FAR struct bmp280_dev_s *priv,
+static uint8_t bmp280_getreg8(struct bmp280_dev_s *priv,
uint8_t regaddr);
-static void bmp280_putreg8(FAR struct bmp280_dev_s *priv,
+static void bmp280_putreg8(struct bmp280_dev_s *priv,
uint8_t regaddr,
uint8_t regval);
/* Character driver methods */
-static int bmp280_open_press(FAR struct file *filep);
-static int bmp280_open_temp(FAR struct file *filep);
-static int bmp280_close_press(FAR struct file *filep);
-static int bmp280_close_temp(FAR struct file *filep);
-static ssize_t bmp280_read_press(FAR struct file *filep, FAR char *buffer,
+static int bmp280_open_press(struct file *filep);
+static int bmp280_open_temp(struct file *filep);
+static int bmp280_close_press(struct file *filep);
+static int bmp280_close_temp(struct file *filep);
+static ssize_t bmp280_read_press(struct file *filep, char *buffer,
size_t buflen);
-static ssize_t bmp280_read_temp(FAR struct file *filep, FAR char *buffer,
+static ssize_t bmp280_read_temp(struct file *filep, char *buffer,
size_t buflen);
Review Comment:
```suggestion
static ssize_t bmp280_read_temp(struct file *filep, char *buffer,
size_t buflen);
```
##########
boards/arm/samv7/samv71-xult/src/sam_mrf24j40.c:
##########
@@ -139,10 +139,10 @@ static struct sam_priv_s g_mrf24j40_mb2_priv =
* irq_enable - Enable or disable the GPIO interrupt
*/
-static int sam_attach_irq(FAR const struct mrf24j40_lower_s *lower,
- xcpt_t handler, FAR void *arg)
+static int sam_attach_irq(const struct mrf24j40_lower_s *lower,
+ xcpt_t handler, void *arg)
Review Comment:
```suggestion
static int sam_attach_irq(const struct mrf24j40_lower_s *lower,
xcpt_t handler, void *arg)
```
##########
boards/arm/stm32/clicker2-stm32/src/stm32_xbee.c:
##########
@@ -219,10 +219,10 @@ static int stm32_attach_attn(FAR const struct
xbee_lower_s *lower,
return OK;
}
-static void stm32_enable_attn(FAR const struct xbee_lower_s *lower,
+static void stm32_enable_attn(const struct xbee_lower_s *lower,
bool state)
Review Comment:
```suggestion
static void stm32_enable_attn(const struct xbee_lower_s *lower,
bool state)
```
##########
boards/arm/samv7/same70-xplained/src/sam_xbee.c:
##########
@@ -163,10 +163,10 @@ static int sam_attach_irq(FAR const struct xbee_lower_s
*lower,
return ret;
}
-static void sam_enable_irq(FAR const struct xbee_lower_s *lower,
+static void sam_enable_irq(const struct xbee_lower_s *lower,
bool state)
Review Comment:
```suggestion
static void sam_enable_irq(const struct xbee_lower_s *lower,
bool state)
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -865,7 +865,7 @@ uint32_t stm32serial_getreg(FAR struct stm32_serial_s
*priv, int offset)
****************************************************************************/
static inline
-void stm32serial_putreg(FAR struct stm32_serial_s *priv,
+void stm32serial_putreg(struct stm32_serial_s *priv,
int offset, uint32_t value)
Review Comment:
```suggestion
void stm32serial_putreg(struct stm32_serial_s *priv,
int offset, uint32_t value)
```
##########
boards/arm/samv7/same70-xplained/src/sam_xbee.c:
##########
@@ -146,10 +146,10 @@ static void sam_reset(FAR const struct xbee_lower_s
*lower)
up_mdelay(100);
}
-static int sam_attach_irq(FAR const struct xbee_lower_s *lower,
- xcpt_t handler, FAR void *arg)
+static int sam_attach_irq(const struct xbee_lower_s *lower,
+ xcpt_t handler, void *arg)
Review Comment:
```suggestion
static int sam_attach_irq(const struct xbee_lower_s *lower,
xcpt_t handler, void *arg)
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -297,53 +297,53 @@ struct stm32_serial_s
****************************************************************************/
#ifndef CONFIG_SUPPRESS_UART_CONFIG
-static void stm32serial_setformat(FAR struct uart_dev_s *dev);
-#endif
-static int stm32serial_setup(FAR struct uart_dev_s *dev);
-static void stm32serial_shutdown(FAR struct uart_dev_s *dev);
-static int stm32serial_attach(FAR struct uart_dev_s *dev);
-static void stm32serial_detach(FAR struct uart_dev_s *dev);
-static int stm32serial_interrupt(int irq, FAR void *context,
- FAR void *arg);
-static int stm32serial_ioctl(FAR struct file *filep, int cmd,
- unsigned long arg);
+static void stm32serial_setformat(struct uart_dev_s *dev);
+#endif
+static int stm32serial_setup(struct uart_dev_s *dev);
+static void stm32serial_shutdown(struct uart_dev_s *dev);
+static int stm32serial_attach(struct uart_dev_s *dev);
+static void stm32serial_detach(struct uart_dev_s *dev);
+static int stm32serial_interrupt(int irq, void *context,
+ void *arg);
+static int stm32serial_ioctl(struct file *filep, int cmd,
+ unsigned long arg);
#ifndef SERIAL_HAVE_ONLY_DMA
-static int stm32serial_receive(FAR struct uart_dev_s *dev,
- FAR unsigned int *status);
-static void stm32serial_rxint(FAR struct uart_dev_s *dev, bool enable);
-static bool stm32serial_rxavailable(FAR struct uart_dev_s *dev);
+static int stm32serial_receive(struct uart_dev_s *dev,
+ unsigned int *status);
+static void stm32serial_rxint(struct uart_dev_s *dev, bool enable);
+static bool stm32serial_rxavailable(struct uart_dev_s *dev);
#endif
#ifdef CONFIG_SERIAL_IFLOWCONTROL
-static bool stm32serial_rxflowcontrol(FAR struct uart_dev_s *dev,
+static bool stm32serial_rxflowcontrol(struct uart_dev_s *dev,
unsigned int nbuffered, bool upper);
#endif
-static void stm32serial_send(FAR struct uart_dev_s *dev, int ch);
-static void stm32serial_txint(FAR struct uart_dev_s *dev, bool enable);
-static bool stm32serial_txready(FAR struct uart_dev_s *dev);
+static void stm32serial_send(struct uart_dev_s *dev, int ch);
+static void stm32serial_txint(struct uart_dev_s *dev, bool enable);
+static bool stm32serial_txready(struct uart_dev_s *dev);
#ifdef SERIAL_HAVE_DMA
-static int stm32serial_dmasetup(FAR struct uart_dev_s *dev);
-static void stm32serial_dmashutdown(FAR struct uart_dev_s *dev);
-static int stm32serial_dmareceive(FAR struct uart_dev_s *dev,
- FAR unsigned int *status);
+static int stm32serial_dmasetup(struct uart_dev_s *dev);
+static void stm32serial_dmashutdown(struct uart_dev_s *dev);
+static int stm32serial_dmareceive(struct uart_dev_s *dev,
+ unsigned int *status);
Review Comment:
```suggestion
static int stm32serial_dmareceive(struct uart_dev_s *dev,
unsigned int *status);
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -297,53 +297,53 @@ struct stm32_serial_s
****************************************************************************/
#ifndef CONFIG_SUPPRESS_UART_CONFIG
-static void stm32serial_setformat(FAR struct uart_dev_s *dev);
-#endif
-static int stm32serial_setup(FAR struct uart_dev_s *dev);
-static void stm32serial_shutdown(FAR struct uart_dev_s *dev);
-static int stm32serial_attach(FAR struct uart_dev_s *dev);
-static void stm32serial_detach(FAR struct uart_dev_s *dev);
-static int stm32serial_interrupt(int irq, FAR void *context,
- FAR void *arg);
-static int stm32serial_ioctl(FAR struct file *filep, int cmd,
- unsigned long arg);
+static void stm32serial_setformat(struct uart_dev_s *dev);
+#endif
+static int stm32serial_setup(struct uart_dev_s *dev);
+static void stm32serial_shutdown(struct uart_dev_s *dev);
+static int stm32serial_attach(struct uart_dev_s *dev);
+static void stm32serial_detach(struct uart_dev_s *dev);
+static int stm32serial_interrupt(int irq, void *context,
+ void *arg);
+static int stm32serial_ioctl(struct file *filep, int cmd,
+ unsigned long arg);
#ifndef SERIAL_HAVE_ONLY_DMA
-static int stm32serial_receive(FAR struct uart_dev_s *dev,
- FAR unsigned int *status);
-static void stm32serial_rxint(FAR struct uart_dev_s *dev, bool enable);
-static bool stm32serial_rxavailable(FAR struct uart_dev_s *dev);
+static int stm32serial_receive(struct uart_dev_s *dev,
+ unsigned int *status);
Review Comment:
```suggestion
static int stm32serial_receive(struct uart_dev_s *dev,
unsigned int *status);
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -876,7 +876,7 @@ void stm32serial_putreg(FAR struct stm32_serial_s *priv,
****************************************************************************/
static inline
-void stm32serial_setusartint(FAR struct stm32_serial_s *priv,
+void stm32serial_setusartint(struct stm32_serial_s *priv,
uint16_t ie)
Review Comment:
```suggestion
void stm32serial_setusartint(struct stm32_serial_s *priv,
uint16_t ie)
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -920,8 +920,8 @@ static void stm32serial_restoreusartint(FAR struct
stm32_serial_s *priv,
* Name: stm32serial_disableusartint
****************************************************************************/
-static void stm32serial_disableusartint(FAR struct stm32_serial_s *priv,
- FAR uint16_t *ie)
+static void stm32serial_disableusartint(struct stm32_serial_s *priv,
+ uint16_t *ie)
Review Comment:
```suggestion
static void stm32serial_disableusartint(struct stm32_serial_s *priv,
uint16_t *ie)
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -904,7 +904,7 @@ void stm32serial_setusartint(FAR struct stm32_serial_s
*priv,
* Name: up_restoreusartint
****************************************************************************/
-static void stm32serial_restoreusartint(FAR struct stm32_serial_s *priv,
+static void stm32serial_restoreusartint(struct stm32_serial_s *priv,
uint16_t ie)
Review Comment:
```suggestion
static void stm32serial_restoreusartint(struct stm32_serial_s *priv,
uint16_t ie)
```
##########
arch/arm/src/stm32u5/stm32_spi.c:
##########
@@ -570,7 +570,7 @@ static inline void spi_putreg8(FAR struct stm32_spidev_s
*priv,
*
****************************************************************************/
-static inline uint16_t spi_getreg16(FAR struct stm32_spidev_s *priv,
+static inline uint16_t spi_getreg16(struct stm32_spidev_s *priv,
uint32_t offset)
Review Comment:
```suggestion
static inline uint16_t spi_getreg16(struct stm32_spidev_s *priv,
uint32_t offset)
```
##########
arch/arm/src/stm32u5/stm32_tim_lowerhalf.c:
##########
@@ -91,14 +91,14 @@ static int stm32_timer_handler(int irq, void *context, void
*arg);
/* "Lower half" driver methods **********************************************/
-static int stm32_start(FAR struct timer_lowerhalf_s *lower);
-static int stm32_stop(FAR struct timer_lowerhalf_s *lower);
-static int stm32_getstatus(FAR struct timer_lowerhalf_s *lower,
- FAR struct timer_status_s *status);
-static int stm32_settimeout(FAR struct timer_lowerhalf_s *lower,
+static int stm32_start(struct timer_lowerhalf_s *lower);
+static int stm32_stop(struct timer_lowerhalf_s *lower);
+static int stm32_getstatus(struct timer_lowerhalf_s *lower,
+ struct timer_status_s *status);
+static int stm32_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout);
-static void stm32_setcallback(FAR struct timer_lowerhalf_s *lower,
- tccb_t callback, FAR void *arg);
+static void stm32_setcallback(struct timer_lowerhalf_s *lower,
+ tccb_t callback, void *arg);
Review Comment:
```suggestion
static void stm32_setcallback(struct timer_lowerhalf_s *lower,
tccb_t callback, void *arg);
```
##########
arch/arm/src/stm32u5/stm32_tim_lowerhalf.c:
##########
@@ -399,11 +399,11 @@ static int stm32_getstatus(FAR struct timer_lowerhalf_s
*lower,
*
****************************************************************************/
-static int stm32_settimeout(FAR struct timer_lowerhalf_s *lower,
+static int stm32_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout)
Review Comment:
```suggestion
static int stm32_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout)
```
##########
boards/arm/samv7/same70-xplained/src/sam_mrf24j40.c:
##########
@@ -156,10 +156,10 @@ static int sam_attach_irq(FAR const struct
mrf24j40_lower_s *lower,
return ret;
}
-static void sam_enable_irq(FAR const struct mrf24j40_lower_s *lower,
+static void sam_enable_irq(const struct mrf24j40_lower_s *lower,
bool state)
Review Comment:
```suggestion
static void sam_enable_irq(const struct mrf24j40_lower_s *lower,
bool state)
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -2462,11 +2462,11 @@ static bool stm32serial_rxflowcontrol(FAR struct
uart_dev_s *dev,
****************************************************************************/
#ifdef SERIAL_HAVE_DMA
-static int stm32serial_dmareceive(FAR struct uart_dev_s *dev,
- FAR unsigned int *status)
+static int stm32serial_dmareceive(struct uart_dev_s *dev,
+ unsigned int *status)
Review Comment:
```suggestion
static int stm32serial_dmareceive(struct uart_dev_s *dev,
unsigned int *status)
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -2378,11 +2378,11 @@ static bool stm32serial_rxavailable(FAR struct
uart_dev_s *dev)
****************************************************************************/
#ifdef CONFIG_SERIAL_IFLOWCONTROL
-static bool stm32serial_rxflowcontrol(FAR struct uart_dev_s *dev,
+static bool stm32serial_rxflowcontrol(struct uart_dev_s *dev,
unsigned int nbuffered, bool upper)
Review Comment:
```suggestion
static bool stm32serial_rxflowcontrol(struct uart_dev_s *dev,
unsigned int nbuffered, bool upper)
```
##########
boards/arm/samv7/samv71-xult/src/sam_mrf24j40.c:
##########
@@ -156,10 +156,10 @@ static int sam_attach_irq(FAR const struct
mrf24j40_lower_s *lower,
return ret;
}
-static void sam_enable_irq(FAR const struct mrf24j40_lower_s *lower,
+static void sam_enable_irq(const struct mrf24j40_lower_s *lower,
bool state)
Review Comment:
```suggestion
static void sam_enable_irq(const struct mrf24j40_lower_s *lower,
bool state)
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -2253,11 +2253,11 @@ static int stm32serial_ioctl(FAR struct file *filep,
int cmd,
****************************************************************************/
#ifndef SERIAL_HAVE_ONLY_DMA
-static int stm32serial_receive(FAR struct uart_dev_s *dev,
- FAR unsigned int *status)
+static int stm32serial_receive(struct uart_dev_s *dev,
+ unsigned int *status)
Review Comment:
```suggestion
static int stm32serial_receive(struct uart_dev_s *dev,
unsigned int *status)
```
##########
boards/arm/samv7/same70-xplained/src/sam_mrf24j40.c:
##########
@@ -139,10 +139,10 @@ static struct sam_priv_s g_mrf24j40_mb2_priv =
* irq_enable - Enable or disable the GPIO interrupt
*/
-static int sam_attach_irq(FAR const struct mrf24j40_lower_s *lower,
- xcpt_t handler, FAR void *arg)
+static int sam_attach_irq(const struct mrf24j40_lower_s *lower,
+ xcpt_t handler, void *arg)
Review Comment:
```suggestion
static int sam_attach_irq(const struct mrf24j40_lower_s *lower,
xcpt_t handler, void *arg)
```
##########
boards/arm/stm32/common/src/stm32_xen1210.c:
##########
@@ -137,11 +137,11 @@ static int xen1210_interrupt(int irq, FAR void *context,
FAR void *arg)
* clear - Acknowledge/clear any pending GPIO interrupt
*/
-static int xen1210_attach(FAR struct xen1210_config_s *state,
- xen1210_handler_t handler, FAR void *arg)
+static int xen1210_attach(struct xen1210_config_s *state,
+ xen1210_handler_t handler, void *arg)
Review Comment:
```suggestion
static int xen1210_attach(struct xen1210_config_s *state,
xen1210_handler_t handler, void *arg)
```
##########
boards/arm/samd2l2/samd21-xplained/src/sam_ug2832hsweg04.c:
##########
@@ -45,10 +45,10 @@
* 10 DISPLAY_RESET 10 PB05 PORT 10 PB15 PORT
* ----------------- ---------------------- ----------------------
* 11 N/C 11 PA08 SERCOM2 PAD[0] 11 PA08 SERCOM2 PAD[0]
- * I�C SDA I�C SDA
+ * I�C SDA I�C SDA
* ----------------- ---------------------- ----------------------
* 12 N/C 12 PA09 SERCOM2 PAD[1] 12 PA09 SERCOM2 PAD[1]
- * I�C SCL I�C SCL
+ * I�C SCL I�C SCL
* ----------------- ---------------------- ----------------------
Review Comment:
please revert
##########
boards/arm/stm32/clicker2-stm32/src/stm32_xbee.c:
##########
@@ -205,10 +205,10 @@ static void stm32_reset(FAR const struct xbee_lower_s
*lower)
up_mdelay(100);
}
-static int stm32_attach_attn(FAR const struct xbee_lower_s *lower,
- xcpt_t handler, FAR void *arg)
+static int stm32_attach_attn(const struct xbee_lower_s *lower,
+ xcpt_t handler, void *arg)
Review Comment:
```suggestion
static int stm32_attach_attn(const struct xbee_lower_s *lower,
xcpt_t handler, void *arg)
```
##########
boards/arm/samd2l2/saml21-xplained/src/sam_ug2832hsweg04.c:
##########
@@ -45,10 +45,10 @@
* 10 DISPLAY_RESET 10 PB05 PORT 10 PB15 PORT
* ----------------- ---------------------- ----------------------
* 11 N/C 11 PA08 SERCOM2 PAD[0] 11 PA08 SERCOM2 PAD[0]
- * I�C SDA I�C SDA
+ * I�C SDA I�C SDA
* ----------------- ---------------------- ----------------------
* 12 N/C 12 PA09 SERCOM2 PAD[1] 12 PA09 SERCOM2 PAD[1]
- * I�C SCL I�C SCL
+ * I�C SCL I�C SCL
Review Comment:
please revert
##########
boards/arm/samd2l2/samd20-xplained/src/sam_ug2832hsweg04.c:
##########
@@ -45,10 +45,10 @@
* 10 DISPLAY_RESET 10 PB05 PORT 10 PB15 PORT
* ----------------- ---------------------- ----------------------
* 11 N/C 11 PA08 SERCOM2 PAD[0] 11 PA08 SERCOM2 PAD[0]
- * I�C SDA I�C SDA
+ * I�C SDA I�C SDA
* ----------------- ---------------------- ----------------------
* 12 N/C 12 PA09 SERCOM2 PAD[1] 12 PA09 SERCOM2 PAD[1]
- * I�C SCL I�C SCL
+ * I�C SCL I�C SCL
* ----------------- ---------------------- ----------------------
Review Comment:
please revert
##########
boards/arm/lpc17xx_40xx/zkit-arm-1769/src/lpc17_40_ssp.c:
##########
@@ -134,7 +134,7 @@ uint8_t lpc17_40_ssp1status(FAR struct spi_dev_s *dev,
uint32_t devid)
****************************************************************************/
#ifdef CONFIG_SPI_CMDDATA
-int weak_function lpc17_40_ssp1cmddata(FAR struct spi_dev_s *dev,
+int weak_function lpc17_40_ssp1cmddata(struct spi_dev_s *dev,
uint32_t devid, bool cmd)
Review Comment:
```suggestion
int weak_function lpc17_40_ssp1cmddata(struct spi_dev_s *dev,
uint32_t devid, bool cmd)
```
##########
arch/arm/src/tiva/common/tiva_can.c:
##########
@@ -210,45 +210,45 @@ struct tiva_can_timing_s
/* Callbacks for upper-half CAN driver */
-static void tivacan_reset(FAR struct can_dev_s *dev);
-static int tivacan_setup(FAR struct can_dev_s *dev);
-static void tivacan_shutdown(FAR struct can_dev_s *dev);
-static void tivacan_rxintctl(FAR struct can_dev_s *dev, bool enable);
-static void tivacan_txintctl(FAR struct can_dev_s *dev, bool enable);
-static int tivacan_ioctl(FAR struct can_dev_s *dev,
+static void tivacan_reset(struct can_dev_s *dev);
+static int tivacan_setup(struct can_dev_s *dev);
+static void tivacan_shutdown(struct can_dev_s *dev);
+static void tivacan_rxintctl(struct can_dev_s *dev, bool enable);
+static void tivacan_txintctl(struct can_dev_s *dev, bool enable);
+static int tivacan_ioctl(struct can_dev_s *dev,
int cmd, unsigned long arg);
-static int tivacan_send(FAR struct can_dev_s *dev,
- FAR struct can_msg_s *msg);
-static bool tivacan_txready(FAR struct can_dev_s *dev);
-static bool tivacan_txempty(FAR struct can_dev_s *dev);
+static int tivacan_send(struct can_dev_s *dev,
+ struct can_msg_s *msg);
+static bool tivacan_txready(struct can_dev_s *dev);
+static bool tivacan_txempty(struct can_dev_s *dev);
/* ISR */
-static int tivacan_isr(int irq, FAR void *context, FAR void *dev);
+static int tivacan_isr(int irq, void *context, void *dev);
/* Internal utility functions */
static struct tiva_can_timing_s
-tivacan_bittiming_get(FAR struct can_dev_s *dev);
+tivacan_bittiming_get(struct can_dev_s *dev);
-static void tivacan_bittiming_set(FAR struct can_dev_s *dev,
- FAR struct tiva_can_timing_s *timing);
+static void tivacan_bittiming_set(struct can_dev_s *dev,
+ struct tiva_can_timing_s *timing);
-int tivacan_alloc_fifo(FAR struct can_dev_s *dev, int depth);
-static void tivacan_free_fifo(FAR struct can_dev_s *dev,
- FAR tiva_can_fifo_t *fifo);
-static void tivacan_disable_mbox(FAR struct can_dev_s *dev,
+int tivacan_alloc_fifo(struct can_dev_s *dev, int depth);
+static void tivacan_free_fifo(struct can_dev_s *dev,
+ tiva_can_fifo_t *fifo);
+static void tivacan_disable_mbox(struct can_dev_s *dev,
uint32_t iface_base,
int num);
-static int tivacan_initfilter(FAR struct can_dev_s *dev,
- FAR tiva_can_fifo_t *fifo,
- FAR void *filter,
+static int tivacan_initfilter(struct can_dev_s *dev,
+ tiva_can_fifo_t *fifo,
+ void *filter,
int type);
Review Comment:
```suggestion
static int tivacan_initfilter(struct can_dev_s *dev,
tiva_can_fifo_t *fifo,
void *filter,
int type);
```
##########
boards/arm/nrf52/nrf52840-dk/src/nrf52_highpri.c:
##########
@@ -80,7 +80,7 @@
struct highpri_s
{
- FAR struct nrf52_tim_dev_s *dev;
+ struct nrf52_tim_dev_s *dev;
volatile uint64_t basepri[16];
volatile uint64_t handler;
volatile uint64_t thread;
Review Comment:
```suggestion
volatile uint64_t basepri[16];
volatile uint64_t handler;
volatile uint64_t thread;
```
##########
boards/arm/kl/freedom-kl25z/src/kl_adxl345.c:
##########
@@ -166,11 +166,11 @@ int adxl345_interrupt(int irq, FAR void *context)
* clear - Acknowledge/clear any pending GPIO interrupt
*/
-static int adxl345_attach(FAR struct adxl345_config_s *state,
- adxl345_handler_t handler, FAR void *arg)
+static int adxl345_attach(struct adxl345_config_s *state,
+ adxl345_handler_t handler, void *arg)
Review Comment:
```suggestion
static int adxl345_attach(struct adxl345_config_s *state,
adxl345_handler_t handler, void *arg)
```
##########
boards/arm/nrf52/nrf52840-dk/src/nrf52_hts221.c:
##########
@@ -93,7 +93,7 @@ static int nrf52_hts221_irq_attach(FAR struct hts221_config_s
*state,
* Name: nrf52_hts221_irq_enable
****************************************************************************/
-static void nrf52_hts221_irq_enable(FAR const struct hts221_config_s *state,
+static void nrf52_hts221_irq_enable(const struct hts221_config_s *state,
bool enable)
Review Comment:
```suggestion
static void nrf52_hts221_irq_enable(const struct hts221_config_s *state,
bool enable)
```
##########
arch/arm/src/stm32u5/stm32_spi.c:
##########
@@ -589,7 +589,7 @@ static inline uint16_t spi_getreg16(FAR struct
stm32_spidev_s *priv,
*
****************************************************************************/
-static inline void spi_putreg16(FAR struct stm32_spidev_s *priv,
+static inline void spi_putreg16(struct stm32_spidev_s *priv,
uint32_t offset, uint16_t value)
Review Comment:
```suggestion
static inline void spi_putreg16(struct stm32_spidev_s *priv,
uint32_t offset, uint16_t value)
```
##########
boards/arm/kinetis/freedom-k28f/src/k28_automount.c:
##########
@@ -167,16 +167,16 @@ static int k28_sdhc_attach(FAR const struct
automount_lower_s *lower,
*
****************************************************************************/
-static void k28_sdhc_enable(FAR const struct automount_lower_s *lower,
+static void k28_sdhc_enable(const struct automount_lower_s *lower,
bool enable)
Review Comment:
```suggestion
static void k28_sdhc_enable(const struct automount_lower_s *lower,
bool enable)
```
##########
boards/arm/kinetis/freedom-k28f/src/k28_automount.c:
##########
@@ -128,15 +128,15 @@ static const struct k28_automount_config_s g_sdhc_config =
*
****************************************************************************/
-static int k28_sdhc_attach(FAR const struct automount_lower_s *lower,
- automount_handler_t isr, FAR void *arg)
+static int k28_sdhc_attach(const struct automount_lower_s *lower,
+ automount_handler_t isr, void *arg)
Review Comment:
```suggestion
static int k28_sdhc_attach(const struct automount_lower_s *lower,
automount_handler_t isr, void *arg)
```
##########
arch/arm/src/stm32u5/stm32_tim_lowerhalf.c:
##########
@@ -447,11 +447,11 @@ static int stm32_settimeout(FAR struct timer_lowerhalf_s
*lower,
*
****************************************************************************/
-static void stm32_setcallback(FAR struct timer_lowerhalf_s *lower,
- tccb_t callback, FAR void *arg)
+static void stm32_setcallback(struct timer_lowerhalf_s *lower,
+ tccb_t callback, void *arg)
Review Comment:
```suggestion
static void stm32_setcallback(struct timer_lowerhalf_s *lower,
tccb_t callback, void *arg)
```
##########
boards/arm/cxd56xx/drivers/sensors/bmp280_scu.c:
##########
@@ -911,14 +911,14 @@ int bmp280_init(FAR struct i2c_master_s *i2c, int port)
*
****************************************************************************/
-int bmp280press_register(FAR const char *devpath, int minor,
- FAR struct i2c_master_s *i2c, int port)
+int bmp280press_register(const char *devpath, int minor,
+ struct i2c_master_s *i2c, int port)
Review Comment:
```suggestion
int bmp280press_register(const char *devpath, int minor,
struct i2c_master_s *i2c, int port)
```
##########
boards/arm/cxd56xx/drivers/sensors/bmp280_scu.c:
##########
@@ -128,39 +128,39 @@
struct bmp280_dev_s
{
- FAR struct i2c_master_s *i2c; /* I2C interface */
- uint8_t addr; /* BMP280 I2C address */
- int freq; /* BMP280 Frequency <= 3.4MHz */
- int port; /* I2C port */
- struct seq_s *seq; /* Sequencer */
- int id; /* Sequencer id */
+ struct i2c_master_s *i2c; /* I2C interface */
+ uint8_t addr; /* BMP280 I2C address */
+ int freq; /* BMP280 Frequency <= 3.4MHz */
+ int port; /* I2C port */
+ struct seq_s *seq; /* Sequencer */
+ int id; /* Sequencer id */
};
/****************************************************************************
* Private Function Prototypes
****************************************************************************/
-static uint8_t bmp280_getreg8(FAR struct bmp280_dev_s *priv,
+static uint8_t bmp280_getreg8(struct bmp280_dev_s *priv,
uint8_t regaddr);
-static void bmp280_putreg8(FAR struct bmp280_dev_s *priv,
+static void bmp280_putreg8(struct bmp280_dev_s *priv,
uint8_t regaddr,
uint8_t regval);
/* Character driver methods */
-static int bmp280_open_press(FAR struct file *filep);
-static int bmp280_open_temp(FAR struct file *filep);
-static int bmp280_close_press(FAR struct file *filep);
-static int bmp280_close_temp(FAR struct file *filep);
-static ssize_t bmp280_read_press(FAR struct file *filep, FAR char *buffer,
+static int bmp280_open_press(struct file *filep);
+static int bmp280_open_temp(struct file *filep);
+static int bmp280_close_press(struct file *filep);
+static int bmp280_close_temp(struct file *filep);
+static ssize_t bmp280_read_press(struct file *filep, char *buffer,
size_t buflen);
Review Comment:
```suggestion
static ssize_t bmp280_read_press(struct file *filep, char *buffer,
size_t buflen);
```
##########
boards/arm/stm32/common/src/stm32_hcsr04.c:
##########
@@ -159,11 +159,11 @@ static void hcsr04_irq_setmode(FAR struct hcsr04_config_s
*state,
/* Enable or disable the GPIO interrupt */
-static void hcsr04_irq_enable(FAR const struct hcsr04_config_s *state,
+static void hcsr04_irq_enable(const struct hcsr04_config_s *state,
bool enable)
Review Comment:
```suggestion
static void hcsr04_irq_enable(const struct hcsr04_config_s *state,
bool enable)
```
##########
arch/arm/src/stm32u5/stm32_tim_lowerhalf.c:
##########
@@ -91,14 +91,14 @@ static int stm32_timer_handler(int irq, void *context, void
*arg);
/* "Lower half" driver methods **********************************************/
-static int stm32_start(FAR struct timer_lowerhalf_s *lower);
-static int stm32_stop(FAR struct timer_lowerhalf_s *lower);
-static int stm32_getstatus(FAR struct timer_lowerhalf_s *lower,
- FAR struct timer_status_s *status);
-static int stm32_settimeout(FAR struct timer_lowerhalf_s *lower,
+static int stm32_start(struct timer_lowerhalf_s *lower);
+static int stm32_stop(struct timer_lowerhalf_s *lower);
+static int stm32_getstatus(struct timer_lowerhalf_s *lower,
+ struct timer_status_s *status);
+static int stm32_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout);
Review Comment:
```suggestion
static int stm32_settimeout(struct timer_lowerhalf_s *lower,
uint32_t timeout);
```
##########
boards/arm/kinetis/freedom-k28f/src/k28_automount.c:
##########
@@ -73,19 +73,19 @@ struct k28_automount_config_s
* struct automount_lower_s to struct k28_automount_config_s
*/
- struct automount_lower_s lower; /* Publicly visible part */
- FAR struct k28_automount_state_s *state; /* Changeable state */
+ struct automount_lower_s lower; /* Publicly visible part */
+ struct k28_automount_state_s *state; /* Changeable state */
};
/****************************************************************************
* Private Function Prototypes
****************************************************************************/
-static int k28_sdhc_attach(FAR const struct automount_lower_s *lower,
- automount_handler_t isr, FAR void *arg);
-static void k28_sdhc_enable(FAR const struct automount_lower_s *lower,
+static int k28_sdhc_attach(const struct automount_lower_s *lower,
+ automount_handler_t isr, void *arg);
+static void k28_sdhc_enable(const struct automount_lower_s *lower,
bool enable);
Review Comment:
```suggestion
static int k28_sdhc_attach(const struct automount_lower_s *lower,
automount_handler_t isr, void *arg);
static void k28_sdhc_enable(const struct automount_lower_s *lower,
bool enable);
```
##########
boards/arm/cxd56xx/drivers/sensors/bmp280_scu.c:
##########
@@ -704,11 +704,11 @@ static int bmp280_close_temp(FAR struct file *filep)
* Name: bmp280_read_press
****************************************************************************/
-static ssize_t bmp280_read_press(FAR struct file *filep, FAR char *buffer,
+static ssize_t bmp280_read_press(struct file *filep, char *buffer,
size_t buflen)
Review Comment:
```suggestion
static ssize_t bmp280_read_press(struct file *filep, char *buffer,
size_t buflen)
```
##########
arch/arm/src/tiva/common/tiva_can.c:
##########
@@ -2041,10 +2041,10 @@ int tivacan_alloc_fifo(FAR struct can_dev_s *dev, int
depth)
* Return value: None
****************************************************************************/
-static void tivacan_free_fifo(FAR struct can_dev_s *dev,
- FAR tiva_can_fifo_t *fifo)
+static void tivacan_free_fifo(struct can_dev_s *dev,
+ tiva_can_fifo_t *fifo)
Review Comment:
```suggestion
static void tivacan_free_fifo(struct can_dev_s *dev,
tiva_can_fifo_t *fifo)
```
##########
boards/arm/cxd56xx/drivers/sensors/rpr0521rs_scu.c:
##########
@@ -802,9 +802,9 @@ static int rpr0521rs_ioctl_ps(FAR struct file *filep,
case SNIOC_GETINTSTATUS:
{
- FAR uint8_t intstatus = rpr0521rs_getreg8(priv,
+ uint8_t intstatus = rpr0521rs_getreg8(priv,
RPR0521RS_INTERRUPT);
Review Comment:
```suggestion
uint8_t intstatus = rpr0521rs_getreg8(priv,
RPR0521RS_INTERRUPT);
```
##########
arch/arm/src/stm32u5/stm32_serial.c:
##########
@@ -297,53 +297,53 @@ struct stm32_serial_s
****************************************************************************/
#ifndef CONFIG_SUPPRESS_UART_CONFIG
-static void stm32serial_setformat(FAR struct uart_dev_s *dev);
-#endif
-static int stm32serial_setup(FAR struct uart_dev_s *dev);
-static void stm32serial_shutdown(FAR struct uart_dev_s *dev);
-static int stm32serial_attach(FAR struct uart_dev_s *dev);
-static void stm32serial_detach(FAR struct uart_dev_s *dev);
-static int stm32serial_interrupt(int irq, FAR void *context,
- FAR void *arg);
-static int stm32serial_ioctl(FAR struct file *filep, int cmd,
- unsigned long arg);
+static void stm32serial_setformat(struct uart_dev_s *dev);
+#endif
+static int stm32serial_setup(struct uart_dev_s *dev);
+static void stm32serial_shutdown(struct uart_dev_s *dev);
+static int stm32serial_attach(struct uart_dev_s *dev);
+static void stm32serial_detach(struct uart_dev_s *dev);
+static int stm32serial_interrupt(int irq, void *context,
+ void *arg);
+static int stm32serial_ioctl(struct file *filep, int cmd,
+ unsigned long arg);
#ifndef SERIAL_HAVE_ONLY_DMA
-static int stm32serial_receive(FAR struct uart_dev_s *dev,
- FAR unsigned int *status);
-static void stm32serial_rxint(FAR struct uart_dev_s *dev, bool enable);
-static bool stm32serial_rxavailable(FAR struct uart_dev_s *dev);
+static int stm32serial_receive(struct uart_dev_s *dev,
+ unsigned int *status);
+static void stm32serial_rxint(struct uart_dev_s *dev, bool enable);
+static bool stm32serial_rxavailable(struct uart_dev_s *dev);
#endif
#ifdef CONFIG_SERIAL_IFLOWCONTROL
-static bool stm32serial_rxflowcontrol(FAR struct uart_dev_s *dev,
+static bool stm32serial_rxflowcontrol(struct uart_dev_s *dev,
unsigned int nbuffered, bool upper);
Review Comment:
```suggestion
static bool stm32serial_rxflowcontrol(struct uart_dev_s *dev,
unsigned int nbuffered, bool upper);
```
##########
boards/arm/cxd56xx/drivers/sensors/rpr0521rs_scu.c:
##########
@@ -670,19 +670,19 @@ static ssize_t rpr0521rs_read_als(FAR struct file *filep,
FAR char *buffer,
* Name: rpr0521rs_read_ps
****************************************************************************/
-static ssize_t rpr0521rs_read_ps(FAR struct file *filep, FAR char *buffer,
+static ssize_t rpr0521rs_read_ps(struct file *filep, char *buffer,
size_t len)
{
- FAR struct inode *inode = filep->f_inode;
- FAR struct rpr0521rs_dev_s *priv = inode->i_private;
+ struct inode *inode = filep->f_inode;
+ struct rpr0521rs_dev_s *priv = inode->i_private;
len = len / RPR0521RS_PS_BYTESPERSAMPLE * RPR0521RS_PS_BYTESPERSAMPLE;
#ifdef CONFIG_RPR0521RS_PROXIMITY_INTERRUPT
if (len)
{
len = RPR0521RS_PS_BYTESPERSAMPLE;
- *(FAR uint16_t *)buffer = rpr0521rs_getreg16(priv,
+ *(uint16_t *)buffer = rpr0521rs_getreg16(priv,
RPR0521RS_PS_DATA_LSB);
Review Comment:
```suggestion
*(uint16_t *)buffer = rpr0521rs_getreg16(priv,
RPR0521RS_PS_DATA_LSB);
```
##########
boards/arm/cxd56xx/drivers/sensors/bmp280_scu.c:
##########
@@ -720,11 +720,11 @@ static ssize_t bmp280_read_press(FAR struct file *filep,
FAR char *buffer,
* Name: bmp280_read_temp
****************************************************************************/
-static ssize_t bmp280_read_temp(FAR struct file *filep, FAR char *buffer,
+static ssize_t bmp280_read_temp(struct file *filep, char *buffer,
size_t buflen)
Review Comment:
```suggestion
static ssize_t bmp280_read_temp(struct file *filep, char *buffer,
size_t buflen)
```
##########
boards/arm/cxd56xx/drivers/sensors/ak09912_scu.c:
##########
@@ -153,13 +153,13 @@ struct ak09912_dev_s
/* Character driver methods */
-static int ak09912_open(FAR struct file *filep);
-static int ak09912_close(FAR struct file *filep);
-static ssize_t ak09912_read(FAR struct file *filep, FAR char *buffer,
+static int ak09912_open(struct file *filep);
+static int ak09912_close(struct file *filep);
+static ssize_t ak09912_read(struct file *filep, char *buffer,
size_t buflen);
-static ssize_t ak09912_write(FAR struct file *filep, FAR const char *buffer,
+static ssize_t ak09912_write(struct file *filep, const char *buffer,
size_t buflen);
Review Comment:
```suggestion
static ssize_t ak09912_write(struct file *filep, const char *buffer,
size_t buflen);
```
##########
boards/arm/cxd56xx/drivers/sensors/ak09912_scu.c:
##########
@@ -235,7 +235,7 @@ static uint8_t ak09912_getreg8(FAR struct ak09912_dev_s
*priv,
*
****************************************************************************/
-static void ak09912_putreg8(FAR struct ak09912_dev_s *priv, uint8_t regaddr,
+static void ak09912_putreg8(struct ak09912_dev_s *priv, uint8_t regaddr,
uint8_t regval)
Review Comment:
```suggestion
static void ak09912_putreg8(struct ak09912_dev_s *priv, uint8_t regaddr,
uint8_t regval)
```
##########
boards/arm/cxd56xx/drivers/sensors/ak09912_scu.c:
##########
@@ -418,7 +418,7 @@ static ssize_t ak09912_read(FAR struct file *filep, FAR
char *buffer,
* Name: ak09912_write
****************************************************************************/
-static ssize_t ak09912_write(FAR struct file *filep, FAR const char *buffer,
+static ssize_t ak09912_write(struct file *filep, const char *buffer,
size_t buflen)
Review Comment:
```suggestion
static ssize_t ak09912_write(struct file *filep, const char *buffer,
size_t buflen)
```
##########
boards/arm/cxd56xx/drivers/audio/cxd56_audio.c:
##########
@@ -71,13 +71,13 @@ struct dnc_param_s
{
bool en;
cxd56_audio_dnc_id_t id;
Review Comment:
```suggestion
cxd56_audio_dnc_id_t id;
```
##########
boards/arm/cxd56xx/drivers/audio/cxd56_audio_ac_reg.c:
##########
@@ -1412,7 +1412,7 @@ void cxd56_audio_ac_reg_set_beep_vol(uint32_t vol)
}
void cxd56_audio_ac_reg_set_cicgain(uint8_t cic_num,
- FAR cxd56_audio_mic_gain_t *gain)
+ cxd56_audio_mic_gain_t *gain)
Review Comment:
```suggestion
cxd56_audio_mic_gain_t *gain)
```
##########
boards/arm/cxd56xx/drivers/sensors/ak09912_scu.c:
##########
@@ -153,13 +153,13 @@ struct ak09912_dev_s
/* Character driver methods */
-static int ak09912_open(FAR struct file *filep);
-static int ak09912_close(FAR struct file *filep);
-static ssize_t ak09912_read(FAR struct file *filep, FAR char *buffer,
+static int ak09912_open(struct file *filep);
+static int ak09912_close(struct file *filep);
+static ssize_t ak09912_read(struct file *filep, char *buffer,
size_t buflen);
Review Comment:
```suggestion
static ssize_t ak09912_read(struct file *filep, char *buffer,
size_t buflen);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
