pkarashchenko commented on code in PR #6092:
URL: https://github.com/apache/incubator-nuttx/pull/6092#discussion_r862523595
##########
arch/arm/src/stm32/stm32_sdadc.c:
##########
@@ -370,7 +370,7 @@ static void sdadc_putreg(FAR struct stm32_dev_s *priv, int
offset,
*
****************************************************************************/
-static void sdadc_modifyreg(FAR struct stm32_dev_s *priv, int offset,
+static void sdadc_modifyreg(struct stm32_dev_s *priv, int offset,
uint32_t clrbits, uint32_t setbits)
Review Comment:
```suggestion
static void sdadc_modifyreg(struct stm32_dev_s *priv, int offset,
uint32_t clrbits, uint32_t setbits)
```
##########
arch/arm/src/stm32f7/stm32_otghost.c:
##########
@@ -1350,12 +1350,12 @@ static int stm32_ctrlep_alloc(FAR struct
stm32_usbhost_s *priv,
*
****************************************************************************/
-static int stm32_xfrep_alloc(FAR struct stm32_usbhost_s *priv,
- FAR const struct usbhost_epdesc_s *epdesc,
- FAR usbhost_ep_t *ep)
+static int stm32_xfrep_alloc(struct stm32_usbhost_s *priv,
+ const struct usbhost_epdesc_s *epdesc,
+ usbhost_ep_t *ep)
Review Comment:
```suggestion
static int stm32_xfrep_alloc(struct stm32_usbhost_s *priv,
const struct usbhost_epdesc_s *epdesc,
usbhost_ep_t *ep)
```
##########
arch/arm/src/stm32h7/stm32_adc.c:
##########
@@ -548,7 +548,7 @@ static void adc_putregm(FAR struct stm32_dev_s *priv, int
offset,
*
****************************************************************************/
-static void adc_modifyregm(FAR struct stm32_dev_s *priv, int offset,
+static void adc_modifyregm(struct stm32_dev_s *priv, int offset,
uint32_t clrbits, uint32_t setbits)
Review Comment:
```suggestion
static void adc_modifyregm(struct stm32_dev_s *priv, int offset,
uint32_t clrbits, uint32_t setbits)
```
##########
arch/arm/src/stm32h7/stm32_adc.c:
##########
@@ -524,7 +524,7 @@ static uint32_t adc_getregm(FAR struct stm32_dev_s *priv,
int offset)
*
****************************************************************************/
-static void adc_putregm(FAR struct stm32_dev_s *priv, int offset,
+static void adc_putregm(struct stm32_dev_s *priv, int offset,
uint32_t value)
Review Comment:
```suggestion
static void adc_putregm(struct stm32_dev_s *priv, int offset,
uint32_t value)
```
##########
arch/arm/src/samd5e5/sam_usb.c:
##########
@@ -7676,12 +7676,12 @@ static ssize_t sam_transfer(FAR struct usbhost_driver_s
*drvr,
****************************************************************************/
#ifdef CONFIG_USBHOST_ASYNCH
-static int sam_asynch(FAR struct usbhost_driver_s *drvr, usbhost_ep_t ep,
- FAR uint8_t *buffer, size_t buflen,
- usbhost_asynch_t callback, FAR void *arg)
+static int sam_asynch(struct usbhost_driver_s *drvr, usbhost_ep_t ep,
+ uint8_t *buffer, size_t buflen,
+ usbhost_asynch_t callback, void *arg)
Review Comment:
```suggestion
static int sam_asynch(struct usbhost_driver_s *drvr, usbhost_ep_t ep,
uint8_t *buffer, size_t buflen,
usbhost_asynch_t callback, void *arg)
```
##########
arch/arm/src/stm32l4/stm32l4_comp.h:
##########
@@ -191,9 +191,9 @@ extern "C"
*
****************************************************************************/
-FAR struct
+struct
comp_dev_s *stm32l4_compinitialize(int intf,
- FAR const struct stm32l4_comp_config_s *cfg);
+ const struct stm32l4_comp_config_s *cfg);
Review Comment:
```suggestion
const struct stm32l4_comp_config_s *cfg);
```
##########
arch/arm/src/sam34/sam4cm_oneshot_lowerhalf.c:
##########
@@ -248,11 +248,11 @@ static int sam_start(FAR struct oneshot_lowerhalf_s
*lower,
*
****************************************************************************/
-static int sam_cancel(FAR struct oneshot_lowerhalf_s *lower,
- FAR struct timespec *ts)
+static int sam_cancel(struct oneshot_lowerhalf_s *lower,
+ struct timespec *ts)
Review Comment:
```suggestion
static int sam_cancel(struct oneshot_lowerhalf_s *lower,
struct timespec *ts)
```
##########
arch/arm/src/stm32f7/stm32_i2c.c:
##########
@@ -960,7 +960,7 @@ stm32_i2c_set_7bit_address(FAR struct stm32_i2c_priv_s
*priv)
****************************************************************************/
static inline void
-stm32_i2c_set_bytes_to_transfer(FAR struct stm32_i2c_priv_s *priv,
+stm32_i2c_set_bytes_to_transfer(struct stm32_i2c_priv_s *priv,
uint8_t n_bytes)
Review Comment:
```suggestion
stm32_i2c_set_bytes_to_transfer(struct stm32_i2c_priv_s *priv,
uint8_t n_bytes)
```
##########
arch/arm/src/stm32h7/stm32_spi.c:
##########
@@ -845,7 +845,7 @@ static inline uint16_t spi_getreg16(FAR struct
stm32_spidev_s *priv,
*
****************************************************************************/
-static inline void spi_putreg16(FAR struct stm32_spidev_s *priv,
+static inline void spi_putreg16(struct stm32_spidev_s *priv,
uint32_t offset, uint16_t value)
Review Comment:
```suggestion
static inline void spi_putreg16(struct stm32_spidev_s *priv,
uint32_t offset, uint16_t value)
```
##########
arch/arm/src/stm32h7/stm32_spi.c:
##########
@@ -826,7 +826,7 @@ static inline void spi_putreg8(FAR struct stm32_spidev_s
*priv,
*
****************************************************************************/
-static inline uint16_t spi_getreg16(FAR struct stm32_spidev_s *priv,
+static inline uint16_t spi_getreg16(struct stm32_spidev_s *priv,
uint32_t offset)
Review Comment:
```suggestion
static inline uint16_t spi_getreg16(struct stm32_spidev_s *priv,
uint32_t offset)
```
##########
arch/arm/src/stm32f7/stm32_otgdev.c:
##########
@@ -4896,11 +4896,11 @@ static void stm32_ep0_stall(FAR struct stm32_usbdev_s
*priv)
*
****************************************************************************/
-static FAR struct usbdev_ep_s *stm32_ep_alloc(FAR struct usbdev_s *dev,
+static struct usbdev_ep_s *stm32_ep_alloc(struct usbdev_s *dev,
uint8_t eplog, bool in,
uint8_t eptype)
Review Comment:
```suggestion
static struct usbdev_ep_s *stm32_ep_alloc(struct usbdev_s *dev,
uint8_t eplog, bool in,
uint8_t eptype)
```
##########
arch/arm/src/stm32l4/stm32l4_comp.h:
##########
@@ -146,7 +146,7 @@ struct stm32l4_comp_config_s
{
struct
{
- FAR const struct comp_callback_s *cb;
+ const struct comp_callback_s *cb;
bool rising;
bool falling;
Review Comment:
```suggestion
bool rising;
bool falling;
```
##########
arch/arm/src/stm32/stm32_sdadc.c:
##########
@@ -347,7 +347,7 @@ static uint32_t sdadc_getreg(FAR struct stm32_dev_s *priv,
int offset)
*
****************************************************************************/
-static void sdadc_putreg(FAR struct stm32_dev_s *priv, int offset,
+static void sdadc_putreg(struct stm32_dev_s *priv, int offset,
uint32_t value)
Review Comment:
```suggestion
static void sdadc_putreg(struct stm32_dev_s *priv, int offset,
uint32_t value)
```
##########
arch/arm/src/stm32l4/stm32l4_lptim.c:
##########
@@ -681,7 +681,7 @@ static int stm32l4_lptim_setcountmode(FAR struct
stm32l4_lptim_dev_s *dev,
* Name: stm32l4_lptim_setpolarity
****************************************************************************/
-static int stm32l4_lptim_setpolarity(FAR struct stm32l4_lptim_dev_s *dev,
+static int stm32l4_lptim_setpolarity(struct stm32l4_lptim_dev_s *dev,
stm32l4_lptim_clkpol_t polarity)
Review Comment:
```suggestion
static int stm32l4_lptim_setpolarity(struct stm32l4_lptim_dev_s *dev,
stm32l4_lptim_clkpol_t polarity)
```
##########
arch/arm/src/stm32f7/stm32_otgdev.c:
##########
@@ -2228,9 +2228,9 @@ static inline void stm32_ep0out_testmode(FAR struct
stm32_usbdev_s *priv,
****************************************************************************/
static inline void stm32_ep0out_stdrequest(struct stm32_usbdev_s *priv,
- FAR struct stm32_ctrlreq_s *ctrlreq)
+ struct stm32_ctrlreq_s *ctrlreq)
Review Comment:
```suggestion
struct stm32_ctrlreq_s *ctrlreq)
```
##########
arch/arm/src/stm32l4/stm32l4_oneshot_lowerhalf.c:
##########
@@ -248,11 +248,11 @@ static int stm32l4_start(FAR struct oneshot_lowerhalf_s
*lower,
*
****************************************************************************/
-static int stm32l4_cancel(FAR struct oneshot_lowerhalf_s *lower,
- FAR struct timespec *ts)
+static int stm32l4_cancel(struct oneshot_lowerhalf_s *lower,
+ struct timespec *ts)
Review Comment:
```suggestion
static int stm32l4_cancel(struct oneshot_lowerhalf_s *lower,
struct timespec *ts)
```
##########
arch/arm/src/stm32h7/stm32_otgdev.c:
##########
@@ -4811,11 +4808,11 @@ static void stm32_ep0_stall(FAR struct stm32_usbdev_s
*priv)
*
****************************************************************************/
-static FAR struct usbdev_ep_s *stm32_ep_alloc(FAR struct usbdev_s *dev,
+static struct usbdev_ep_s *stm32_ep_alloc(struct usbdev_s *dev,
uint8_t eplog, bool in,
uint8_t eptype)
Review Comment:
```suggestion
static struct usbdev_ep_s *stm32_ep_alloc(struct usbdev_s *dev,
uint8_t eplog, bool in,
uint8_t eptype)
```
##########
arch/arm/src/stm32l4/stm32l4_oneshot_lowerhalf.c:
##########
@@ -196,12 +196,12 @@ static int stm32l4_max_delay(FAR struct
oneshot_lowerhalf_s *lower,
*
****************************************************************************/
-static int stm32l4_start(FAR struct oneshot_lowerhalf_s *lower,
- oneshot_callback_t callback, FAR void *arg,
- FAR const struct timespec *ts)
+static int stm32l4_start(struct oneshot_lowerhalf_s *lower,
+ oneshot_callback_t callback, void *arg,
+ const struct timespec *ts)
Review Comment:
```suggestion
static int stm32l4_start(struct oneshot_lowerhalf_s *lower,
oneshot_callback_t callback, void *arg,
const struct timespec *ts)
```
##########
arch/arm/src/stm32l4/stm32l4_tim.c:
##########
@@ -1060,7 +1060,7 @@ static uint32_t stm32l4_tim_getclock(FAR struct
stm32l4_tim_dev_s *dev)
* Name: stm32l4_tim_setperiod
****************************************************************************/
-static void stm32l4_tim_setperiod(FAR struct stm32l4_tim_dev_s *dev,
+static void stm32l4_tim_setperiod(struct stm32l4_tim_dev_s *dev,
uint32_t period)
{
Review Comment:
```suggestion
static void stm32l4_tim_setperiod(struct stm32l4_tim_dev_s *dev,
uint32_t period)
{
```
##########
arch/arm/src/stm32l4/stm32l4_i2c.c:
##########
@@ -2506,11 +2506,11 @@ static int stm32l4_i2c_deinit(FAR struct
stm32l4_i2c_priv_s *priv)
*
****************************************************************************/
-static int stm32l4_i2c_process(FAR struct i2c_master_s *dev,
- FAR struct i2c_msg_s *msgs, int count)
+static int stm32l4_i2c_process(struct i2c_master_s *dev,
+ struct i2c_msg_s *msgs, int count)
{
struct stm32l4_i2c_inst_s *inst = (struct stm32l4_i2c_inst_s *)dev;
Review Comment:
```suggestion
struct stm32l4_i2c_inst_s *inst = (struct stm32l4_i2c_inst_s *)dev;
```
##########
arch/arm/src/stm32h7/stm32_spi.c:
##########
@@ -1585,7 +1585,7 @@ static int spi_setdelay(struct spi_dev_s *dev, uint32_t
startdelay,
uint32_t stopdelay, uint32_t csdelay,
uint32_t ifdelay)
Review Comment:
```suggestion
uint32_t ifdelay)
```
##########
arch/arm/src/stm32l4/stm32l4_otgfsdev.c:
##########
@@ -4932,11 +4930,11 @@ static void stm32l4_ep0_stall(FAR struct
stm32l4_usbdev_s *priv)
*
****************************************************************************/
-static FAR struct usbdev_ep_s *stm32l4_ep_alloc(FAR struct usbdev_s *dev,
+static struct usbdev_ep_s *stm32l4_ep_alloc(struct usbdev_s *dev,
uint8_t eplog, bool in,
uint8_t eptype)
Review Comment:
```suggestion
static struct usbdev_ep_s *stm32l4_ep_alloc(struct usbdev_s *dev,
uint8_t eplog, bool in,
uint8_t eptype)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
