pussuw commented on PR #6134: URL: https://github.com/apache/incubator-nuttx/pull/6134#issuecomment-1110623077
@masayuki2009 I also did testing on icicle:nsh (BUILD_FLAT) and it works with and without this patch. However, with icicle:knsh (BUILD_PROTECTED) the issue is 100% reproducible. FPU gets enabled, but ostest does not run fpu_test as it only compiles with build flat. With knsh, the system crashes at random locations during ostest, which has never completed successfully **without** this patch, and I have not seen an error **with* this patch. The way I found this (potential) issue, is by bisecting: 5b6dd876b87196cc82dd45258d77e22d0c8b033b <- good commit (risc-v/riscv_assert.c Fix dumping of status from ISR) c29a3b7bd89c45d3781133679ae875e0e835bdd4 <- bad commit (pipe: Increase buffer size by one byte to ompensate the full indicator) So somewhere between those two commits there is an issue. 48b81bda0904a426360fa809fd747e3966d29024 <- (arch/risc-v: Change riscv_savefpu/riscv_loadfpu to macro) by partially reverting this commit the crash goes away. The partial revert is to move loadfpu back to where it was prior to 48b8... So this is how I made this patch. Of course there can be some other issue and I just masked it with this patch. One clear candidate can be `riscv_get_newintctx()`, because ostest creates / destroys new tasks for certain tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
