pkarashchenko commented on a change in pull request #5915:
URL: https://github.com/apache/incubator-nuttx/pull/5915#discussion_r840004619
##########
File path: include/nuttx/sched_note.h
##########
@@ -105,16 +105,32 @@
memset((s), 0, sizeof(struct note_filter_irq_s))
#endif
-/* Note dump module tag definitions */
-
#ifdef CONFIG_SCHED_INSTRUMENTATION_DUMP
-# define NOTE_MODULE(a, b, c, d) \
- ((uint32_t)((a) & 0xff) | \
- ((uint32_t)((b) & 0xff) << 8) | \
- ((uint32_t)((c) & 0xff) << 16) | \
- ((uint32_t)((d) & 0xff) << 24))
+# define SCHED_NOTE_IP \
+ ({__label__ sched_note_here; sched_note_here:
(uintptr_t)&&sched_note_here;})
Review comment:
Maybe we can reuse `__LINE__` macro to generate unique labels? In this
case we can still keep `sched_note_string` with `uint32_t` parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
