gustavonihei commented on a change in pull request #5721:
URL: https://github.com/apache/incubator-nuttx/pull/5721#discussion_r825080609
##########
File path: sched/init/nx_start.c
##########
@@ -628,15 +628,6 @@ void nx_start(void)
irq_initialize();
}
- /* Initialize the watchdog facility (if included in the link) */
-
-#ifdef CONFIG_HAVE_WEAKFUNCTIONS
- if (wd_initialize != NULL)
-#endif
Review comment:
`wd_initialize` is defined as a weak, so the user is able to override it
with a custom initialization procedure.
So, to a certain extent, this is a breaking change, isn't it?
It will impact anyone that may be relying on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
