xiaoxiang781216 commented on a change in pull request #5662:
URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r818631764
##########
File path: arch/arm/src/armv7-r/Toolchain.defs
##########
@@ -67,6 +67,29 @@ else
MAXOPTIMIZATION += -fomit-frame-pointer
endif
+ifeq ($(CONFIG_ARCH_FPU),y)
+ ARCHCPUFLAGS += -mfpu=vfpv3-d16
+ ifeq ($(CONFIG_ARM_FPU_ABI_SOFT),y)
+ ARCHCPUFLAGS += -mfloat-abi=softfp
+ else
+ ARCHCPUFLAGS += -mfloat-abi=hard
+ endif
+else
+ ARCHCPUFLAGS += -mfloat-abi=soft
+endif
+
+ifeq ($(CONFIG_ENDIAN_BIG),y)
+ ARCHCPUFLAGS += -mbig-endian
+endif
+
+ifeq ($(CONFIG_ARCH_CORTEXR4),y)
Review comment:
move before line 70 to keep the same order as other Toolchain.defs
##########
File path: arch/arm/Kconfig
##########
@@ -889,18 +899,31 @@ config ARM_HAVE_WFE_SEV
config ARM_HAVE_FPU_D32
bool
- select ARCH_HAVE_FPU
default n
+ depends on ARCH_DPFPU
---help---
- FPU implemented in the VFPv3-D32 format that supports
+ FPU implemented in the VFPv[3|4]-D32 format that supports
32 double-precision floating-point registers.
config ARM_HAVE_NEON
bool
default n
+ depends on ARM_HAVE_FPU_D32
Review comment:
select
##########
File path: arch/arm/Kconfig
##########
@@ -889,18 +899,31 @@ config ARM_HAVE_WFE_SEV
config ARM_HAVE_FPU_D32
Review comment:
change to ARM_HAVE_DPFPU32
##########
File path: arch/arm/Kconfig
##########
@@ -889,18 +899,31 @@ config ARM_HAVE_WFE_SEV
config ARM_HAVE_FPU_D32
bool
- select ARCH_HAVE_FPU
default n
+ depends on ARCH_DPFPU
Review comment:
select ARCH_HAVE_DPFPU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
