gustavonihei commented on a change in pull request #5336:
URL: https://github.com/apache/incubator-nuttx/pull/5336#discussion_r809499761



##########
File path: arch/xtensa/src/esp32/esp32_irq.c
##########
@@ -728,12 +738,13 @@ int esp32_cpuint_initialize(void)
    *   ESP32_CPUINT_PROFILING  11  Not yet defined
    *   ESP32_CPUINT_TIMER1     15  XTENSA_IRQ_TIMER1  1
    *   ESP32_CPUINT_TIMER2     16  XTENSA_IRQ_TIMER2  2
-   *   ESP32_CPUINT_SOFTWARE1  29  Not yet defined
+   *   ESP32_CPUINT_SOFTWARE1  29  XTENSA_IRQ_SWINT

Review comment:
       ```suggestion
      *   ESP32_CPUINT_SOFTWARE1  29  XTENSA_IRQ_SWINT  4
   ```
   Also, as `ESP32_IRQ_MAC` is the first peripheral interrupt, it will get 
shifted to the index 5, as defined here:
   
https://github.com/apache/incubator-nuttx/blob/master/arch/xtensa/include/esp32/irq.h#L195




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to