pkarashchenko commented on a change in pull request #5483:
URL: https://github.com/apache/incubator-nuttx/pull/5483#discussion_r806142300
##########
File path: include/dsp.h
##########
@@ -529,31 +535,32 @@ void foc_vdq_mag_max_get(FAR struct foc_data_f32_s *foc,
FAR float *max);
/* BLDC/PMSM motor observers */
-void motor_observer_init(FAR struct motor_observer_f32_s *observer,
- FAR void *ao, FAR void *so, float per);
-float motor_observer_speed_get(FAR struct motor_observer_f32_s *o);
-float motor_observer_angle_get(FAR struct motor_observer_f32_s *o);
+void motor_sobserver_init(FAR struct motor_sobserver_f32_s *observer,
+ FAR void *so, float per);
+void motor_aobserver_init(FAR struct motor_aobserver_f32_s *observer,
+ FAR void *ao, float per);
Review comment:
```suggestion
void motor_aobserver_init(FAR struct motor_aobserver_f32_s *observer,
FAR void *ao, float per);
```
##########
File path: include/dsp.h
##########
@@ -529,31 +535,32 @@ void foc_vdq_mag_max_get(FAR struct foc_data_f32_s *foc,
FAR float *max);
/* BLDC/PMSM motor observers */
-void motor_observer_init(FAR struct motor_observer_f32_s *observer,
- FAR void *ao, FAR void *so, float per);
-float motor_observer_speed_get(FAR struct motor_observer_f32_s *o);
-float motor_observer_angle_get(FAR struct motor_observer_f32_s *o);
+void motor_sobserver_init(FAR struct motor_sobserver_f32_s *observer,
+ FAR void *so, float per);
+void motor_aobserver_init(FAR struct motor_aobserver_f32_s *observer,
+ FAR void *ao, float per);
+float motor_sobserver_speed_get(FAR struct motor_sobserver_f32_s *o);
+float motor_aobserver_angle_get(FAR struct motor_aobserver_f32_s *o);
-void motor_observer_smo_init(FAR struct motor_observer_smo_f32_s *smo,
- float kslide, float err_max);
-void motor_observer_smo(FAR struct motor_observer_f32_s *o,
- FAR ab_frame_f32_t *i_ab, FAR ab_frame_f32_t *v_ab,
- FAR struct motor_phy_params_f32_s *phy, float dir);
+void motor_aobserver_smo_init(FAR struct motor_aobserver_smo_f32_s *smo,
+ float kslide, float err_max);
+void motor_aobserver_smo(FAR struct motor_aobserver_f32_s *o,
+ FAR ab_frame_f32_t *i_ab, FAR ab_frame_f32_t *v_ab,
+ FAR struct motor_phy_params_f32_s *phy, float dir,
+ float speed);
void motor_sobserver_div_init(FAR struct motor_sobserver_div_f32_s *so,
uint8_t samples, float filer, float per);
-void motor_sobserver_div(FAR struct motor_observer_f32_s *o,
- float angle, float dir);
+void motor_sobserver_div(FAR struct motor_sobserver_f32_s *o, float angle);
-void motor_observer_nfo_init(FAR struct motor_observer_nfo_f32_s *nfo);
-void motor_observer_nfo(FAR struct motor_observer_f32_s *o,
+void motor_aobserver_nfo_init(FAR struct motor_aobserver_nfo_f32_s *nfo);
+void motor_aobserver_nfo(FAR struct motor_aobserver_f32_s *o,
FAR ab_frame_f32_t *i_ab, FAR ab_frame_f32_t *v_ab,
FAR struct motor_phy_params_f32_s *phy, float gain);
Review comment:
```suggestion
void motor_aobserver_nfo(FAR struct motor_aobserver_f32_s *o,
FAR ab_frame_f32_t *i_ab, FAR ab_frame_f32_t *v_ab,
FAR struct motor_phy_params_f32_s *phy, float gain);
```
##########
File path: libs/libdsp/lib_observer.c
##########
@@ -547,12 +571,12 @@ void motor_observer_nfo_init(FAR struct
motor_observer_nfo_f32_s *nfo)
*
****************************************************************************/
-void motor_observer_nfo(FAR struct motor_observer_f32_s *o,
+void motor_aobserver_nfo(FAR struct motor_aobserver_f32_s *o,
FAR ab_frame_f32_t *i_ab, FAR ab_frame_f32_t *v_ab,
FAR struct motor_phy_params_f32_s *phy, float gain)
Review comment:
```suggestion
void motor_aobserver_nfo(FAR struct motor_aobserver_f32_s *o,
FAR ab_frame_f32_t *i_ab, FAR ab_frame_f32_t *v_ab,
FAR struct motor_phy_params_f32_s *phy, float gain)
```
##########
File path: include/dsp.h
##########
@@ -529,31 +535,32 @@ void foc_vdq_mag_max_get(FAR struct foc_data_f32_s *foc,
FAR float *max);
/* BLDC/PMSM motor observers */
-void motor_observer_init(FAR struct motor_observer_f32_s *observer,
- FAR void *ao, FAR void *so, float per);
-float motor_observer_speed_get(FAR struct motor_observer_f32_s *o);
-float motor_observer_angle_get(FAR struct motor_observer_f32_s *o);
+void motor_sobserver_init(FAR struct motor_sobserver_f32_s *observer,
+ FAR void *so, float per);
Review comment:
```suggestion
void motor_sobserver_init(FAR struct motor_sobserver_f32_s *observer,
FAR void *so, float per);
```
##########
File path: libs/libdsp/lib_observer.c
##########
@@ -61,33 +60,64 @@
*
****************************************************************************/
-void motor_observer_init(FAR struct motor_observer_f32_s *observer,
- FAR void *ao, FAR void *so, float per)
+void motor_sobserver_init(FAR struct motor_sobserver_f32_s *observer,
+ FAR void *so, float per)
Review comment:
```suggestion
void motor_sobserver_init(FAR struct motor_sobserver_f32_s *observer,
FAR void *so, float per)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
