zhaoxiu-zeng commented on a change in pull request #5171:
URL: https://github.com/apache/incubator-nuttx/pull/5171#discussion_r779272504
##########
File path: sched/semaphore/sem_holder.c
##########
@@ -187,35 +194,36 @@ nxsem_findorallocateholder(sem_t *sem, FAR struct tcb_s
*htcb)
static inline void nxsem_freeholder(sem_t *sem,
FAR struct semholder_s *pholder)
{
-#if CONFIG_SEM_PREALLOCHOLDERS > 0
- FAR struct semholder_s *curr;
- FAR struct semholder_s *prev;
-#endif
+ FAR struct semholder_s **curr;
Review comment:
Applied, thanks!
##########
File path: include/semaphore.h
##########
@@ -58,19 +58,23 @@
#ifdef CONFIG_PRIORITY_INHERITANCE
struct tcb_s; /* Forward reference */
+struct sem_s;
+
struct semholder_s
{
#if CONFIG_SEM_PREALLOCHOLDERS > 0
- struct semholder_s *flink; /* Implements singly linked list */
+ struct semholder_s *flink; /* List of semphore's holder */
Review comment:
Applied, thanks!
##########
File path: include/semaphore.h
##########
@@ -58,19 +58,23 @@
#ifdef CONFIG_PRIORITY_INHERITANCE
struct tcb_s; /* Forward reference */
+struct sem_s;
+
struct semholder_s
{
#if CONFIG_SEM_PREALLOCHOLDERS > 0
- struct semholder_s *flink; /* Implements singly linked list */
+ struct semholder_s *flink; /* List of semphore's holder */
#endif
- FAR struct tcb_s *htcb; /* Holder TCB */
+ struct semholder_s *tlink; /* List of task held semphores */
Review comment:
Applied, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
