davids5 commented on pull request #5012: URL: https://github.com/apache/incubator-nuttx/pull/5012#issuecomment-997395266
> as we are going to remove at least GPIO_SPEED_50MHz, GPIO_PUSHPULL, GPIO_PULLUP I would only remove GPIO_SPEED_xxMHz, not GPIO_PUSHPULL nor GPIO_PULLUP if the setting make make sense for the pin. Most are correct. The port encoding is one more place for an error to happen in is not FNF. It is not generically usable: What are you going to do on processors have pad names like GPIO_AD_B1_15 call it GPIO_SDMMC2_CMD_GPIO_AD_B0_10. I would appose the pad encoding in the name change 100%. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
