a-lunev edited a comment on pull request #5012: URL: https://github.com/apache/incubator-nuttx/pull/5012#issuecomment-997335273
> If you change ALL the _n to a value Pnn you cause massive churn that IMO added very little value as it only duplicates information in from the define into the name. - Hence I said I am not a Fan of that change. As we are going to remove at least GPIO_SPEED_50MHz, GPIO_PUSHPULL, GPIO_PULLUP from all existing pinmap files, it will be a massive churn in any case. If we start doing this, I think it is reasonable to do it with the most effective strategy. I think we should avoid a half-hearted massive code refactoring in this case. The highest value of using port name+number in the define names (vs _n naming) is in board.h files. GPIO_SDMMC2_CMD_PA0 define name is much better compared to GPIO_SDMMC2_CMD_1 in board.h. GPIO_SDMMC2_CMD_PA0 gives you a total picture what the pin is. GPIO_SDMMC2_CMD_1 is just confusing and error-prone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
