tito97sp commented on a change in pull request #4908:
URL: https://github.com/apache/incubator-nuttx/pull/4908#discussion_r757923303
##########
File path: boards/arm/stm32h7/nucleo-h743zi/configs/mcuboot-app/defconfig
##########
@@ -0,0 +1,142 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed
.config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that
includes your
+# modifications.
+#
+# CONFIG_SPI_EXCHANGE is not set
+# CONFIG_STM32H7_SYSCFG is not set
+CONFIG_APP_FORMAT_MCUBOOT=y
+CONFIG_APP_MCUBOOT_BOOTLOADER=y
Review comment:
I like the option of renaming both APP_FORMAT_MCUBOOT and
APP_MCUBOOT_BOOTLOADER to STM32_FORMAT_MCUBOOT and STM32_MCUBOOT_BOOTLOADER.
Nevertheless as they are not specific configurations of STM32 boards I think
they could be confusing in the future. Maybe it should be a standardized way of
configuring the mcuboot for every boards and archs.
##########
File path: boards/arm/stm32h7/nucleo-h743zi/Kconfig
##########
@@ -27,4 +27,66 @@ config STM32_ROMFS_IMAGEFILE
depends on STM32_ROMFS
default "../../../rom.img"
+
+config PROGMEM_OTA_PARTITION
+ bool "Progmem ota partitions"
+ default n
+ select MTD
+ select MTD_BYTE_WRITE
+ select MTD_PARTITION
+ select MTD_PROGMEM
+ select MTD_PROGMEM_ERASESTATE
+
+menuconfig STM32_APP_FORMAT_MCUBOOT
+ bool "MCUboot-bootable format"
+ default n
+ select PROGMEM_OTA_PARTITION
+ ---help---
+ The MCUboot support of loading the firmware images.
+
+if STM32_APP_FORMAT_MCUBOOT
Review comment:
Yes sorry. I forget. Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
