[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4639: tcp_timer: eliminated false decrements of conn->timer in case of multiple network adapters.

[GitBox]

xiaoxiang781216 commented on a change in pull request #4639:
URL: https://github.com/apache/incubator-nuttx/pull/4639#discussion_r726265388



##########
File path: net/devif/devif_poll.c
##########
@@ -361,17 +363,22 @@ static inline int devif_poll_icmp(FAR struct net_driver_s 
*dev,
 
   while (!bstop && (conn = icmp_nextconn(conn)) != NULL)
     {
-      /* Perform the ICMP poll */
+      /* Skip ICMP connections that are bound to other polling devices */
 
-      icmp_poll(dev, conn);
+      if (dev == conn->dev)

Review comment:
       why ICMP has different condition against ICMPv6?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org