a-lunev commented on pull request #4639:
URL: https://github.com/apache/incubator-nuttx/pull/4639#issuecomment-939178536


   > LGTM,
   > 
   > Seems that other protocol would be better to include similar device 
checks, how about add more checks in 
devif_poll_[icmp/udp/tcp/packet/...]_connections ? I just noticed protocol CAN 
has already include this check:
   > 
   > 
https://github.com/apache/incubator-nuttx/blob/master/net/devif/devif_poll.c#L253
   
   Concerning the other protocols, dev field of ***_conn_s structures is not 
supported in udp (unbuffered), bluetooth, ieee802154 and pkt. I'm not sure if 
there are more obstacles?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to