xiaoxiang781216 commented on a change in pull request #3517:
URL: https://github.com/apache/incubator-nuttx/pull/3517#discussion_r612100073
##########
File path: include/nuttx/arch.h
##########
@@ -308,9 +308,26 @@ int up_use_stack(FAR struct tcb_s *tcb, FAR void *stack,
size_t stack_size);
*
* - adj_stack_size: Stack size after removal of the stack frame from
* the stack
- * - adj_stack_ptr: Adjusted initial stack pointer after the frame has
- * been removed from the stack. This will still be the initial value
- * of the stack pointer when the task is started.
+ * - adj_stack_ptr: Adjusted stack base pointer after the TLS Data and
+ * Arguments has been removed from the stack allocation.
+ *
+ * Here is the diagram after some allocation(tls, arg):
+ *
+ * +-------------+ <-stack_alloc_ptr(lowest)
+ * | TLS Data |
+ * +-------------+
+ * | Arguments |
+ * adj_stack_ptr-> +-------------+\
+ * | Available | +
+ * | Stack | |
+ * | | | |
+ * | | | |
+ * v | | +->adj_stack_size
+ * | | |
+ * | | |
+ * +-------------+ |
+ * | Thread Data | +
+ * +-------------+/
Review comment:
Ok, add to here:
https://github.com/apache/incubator-nuttx/pull/3517/files#diff-b0e4e9a1378b2a5ded4af14faa20cd4fea7cc12ae8d832df45817891718734eaR126-R142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
