v01d edited a comment on pull request #3517:
URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-818284700


   > > Sorry, I can't really review this change as I'm not really familiar with 
this part of the codebase.
   > 
   > There are five commits. Most deal with other issues that you could 
probably have input on. Otherwise, @davids5 will need to do the merge (ONLY 
after we are sure that 10.1 is protected from the changes).
   
   I looked at the changes of each commit. I don't really understand much of 
this so I can't provide a meaningful review (I get the gist of it mostly). 
Anyway, I think even for an expert it would still be hard to catch a bug here. 
I think a test that can be run for each arch would be ideal. Maybe there's 
something that could be setup specially for this change? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to