[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3050: Added support for multiple syslog channels.

[GitBox]

xiaoxiang781216 commented on a change in pull request #3050:
URL: https://github.com/apache/incubator-nuttx/pull/3050#discussion_r593928197



##########
File path: drivers/syslog/syslog_channel.c
##########
@@ -141,8 +145,14 @@ int syslog_channel(FAR const struct syslog_channel_s 
*channel)
     {
       DEBUGASSERT(channel->sc_putc != NULL && channel->sc_force != NULL);
 
-      g_syslog_channel = channel;
-      return OK;
+      for (int i = 0; i < CONFIG_SYSLOG_MAX_CHANNELS; i++)

Review comment:
       Maybe, we can change syslog_channel behaviour base on the value of 
CONFIG_SYSLOG_MAX_CHANNELS:
   
   1. Use the replacement semantics when CONFIG_SYSLOG_MAX_CHANNELS == 1
   2. Use the addition semantics when CONFIG_SYSLOG_MAX_CHANNELS > 1
   
   At least, we should allow user switch to syslog_file_channel when 
CONFIG_SYSLOG_MAX_CHANNELS equals 1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org