v01d commented on pull request #3050: URL: https://github.com/apache/incubator-nuttx/pull/3050#issuecomment-798929593
> > BTW, I'm not following how this interacts with Kconfig. Right now there are some options that indicate where to send syslog via a choice and other options. If this enables multiple outputs, shouldn't that be changed to a multiple choice? Kconfig options for syslog are also a bit messy, so any improvement in that sense would also be welcome. > > I mentioned Kconfig in the broader sense, compared to providing just a another board config. > Generally, for me, Kconfig help entries are the first stop in looking for information for a feature. I understand, I was simply mentioning that I didn't quite get how the change introduced in this PR works in conjunction with existing options as I see those are not affected by this PR, as it is not clear from the PR description. > > Let's finalize the interface of the new functionality first, and then I will update the documentation. And possibly improve syslog Kconfig in general... I personally think that the best time to update docs to account for changes in a PR is as part of the PR itself. Changing the docs is just changing a text file. Most of the time the subsequent doc update PR never happens (not saying this is your case, just an observation of past PRs). If you want to make the change to the docs in another PR, go ahead. I just think it would be a good practice to adopt. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
