acassis commented on a change in pull request #2888:
URL: https://github.com/apache/incubator-nuttx/pull/2888#discussion_r580475489
##########
File path: boards/xtensa/esp32/esp32-wrover-kit/src/esp32_bringup.c
##########
@@ -259,6 +263,20 @@ int esp32_bringup(void)
}
#endif
+#ifdef CONFIG_SENSORS_BMP180
+ /* Try to register BMP180 device in I2C0 */
+
+ ret = board_bmp180_initialize(0, 0);
+
Review comment:
BTW, there is not a fixed rule about this spacing, so I will merge your
patch anyway. Normally I try to duplicate Mr. Greg style, for example:
mm/shm/shmctl.c and drivers/loop/losetup.c
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
