Ouss4 commented on a change in pull request #2888:
URL: https://github.com/apache/incubator-nuttx/pull/2888#discussion_r580077397



##########
File path: boards/xtensa/esp32/esp32-wrover-kit/src/esp32_bringup.c
##########
@@ -259,6 +264,24 @@ int esp32_bringup(void)
     }
 #endif
 
+#ifdef CONFIG_SENSORS_BMP180
+  ret = board_bmp180_initialize(0, 0);
+
+  if (ret < 0)
+    {
+      syslog(LOG_ERR, "Failed to initialize BMP180
+                       Driver for I2C0: %d\n", ret);
+      ret2 = board_bmp180_initialize(0, 1);

Review comment:
       ~~Why are you using two I2C buses to connect two devices?  And why 2 of 
the same device?~~
   Never mind I see it's not registering two devices, however why are searching 
in the 2 buses?  The device is supposed to be connected to a bus in the board, 
this is something we should know.  So just use the bus you connected your 
device to.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to