yamt commented on a change in pull request #2832:
URL: https://github.com/apache/incubator-nuttx/pull/2832#discussion_r573502159
##########
File path: arch/xtensa/Kconfig
##########
@@ -128,15 +128,23 @@ config XTENSA_USE_SEPARATE_IMEM
This separate heap will be part of the internal DRAM. It
starts right after .data
and ends at the configurable size given by the OPTION
XTENSA_IMEM_REGION_SIZE.
+config XTENSA_IMEM_MAXIMIZE_HEAP_REGION
+ bool "Use a maximum separate heap for internal memory"
+ default n
+ depends on XTENSA_IMM_USE_SEPARATE_HEAP
+ help
+ This separate heap will be part of the internal DRAM. It
starts right after .data
+ and ends at the (HEAP_REGION1_END - HEAP_REGION_OFFSET).
+
config XTENSA_IMEM_REGION_SIZE
hex "DRAM region size for internal use"
- depends on XTENSA_USE_SEPARATE_IMEM
+ depends on XTENSA_IMM_USE_SEPARATE_HEAP &&
!XTENSA_IMEM_MAXIMIZE_HEAP_REGION
Review comment:
it's better to be consistent at least within Kconfig. this seems like
the only place IMM is used. @gustavonihei how do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
