gustavonihei commented on a change in pull request #2832:
URL: https://github.com/apache/incubator-nuttx/pull/2832#discussion_r572954028
##########
File path: arch/xtensa/Kconfig
##########
@@ -128,9 +128,17 @@ config XTENSA_USE_SEPARATE_IMEM
This separate heap will be part of the internal DRAM. It
starts right after .data
and ends at the configurable size given by the OPTION
XTENSA_IMEM_REGION_SIZE.
+config XTENSA_IMEM_REGION_SIZE_MAX
+ bool "Use a maximum separate heap for internal memory"
+ default n
+ depends on XTENSA_USE_SEPARATE_IMEM
Review comment:
Another suggestion: the `XTENSA_USE_SEPARATE_IMEM` should explicitly
inform that it intends to use a separate heap region (e.g.:
`XTENSA_IMM_USE_SEPARATE_HEAP`)
##########
File path: arch/xtensa/Kconfig
##########
@@ -128,9 +128,17 @@ config XTENSA_USE_SEPARATE_IMEM
This separate heap will be part of the internal DRAM. It
starts right after .data
and ends at the configurable size given by the OPTION
XTENSA_IMEM_REGION_SIZE.
+config XTENSA_IMEM_REGION_SIZE_MAX
Review comment:
Although `XTENSA_IMEM_REGION_SIZE_MAX` and `XTENSA_IMEM_REGION_SIZE`
share similar names, they refer to different aspects of the memory.
`XTENSA_IMEM_REGION_SIZE` refers to the **DRAM** region size, while
`XTENSA_IMEM_REGION_SIZE_MAX` refers just to the heap region.
Furthermore, I suggest to rename `XTENSA_IMEM_REGION_SIZE_MAX` to
`XTENSA_IMEM_MAXIMIZE_HEAP_REGION`, so it becomes more adequate to a **bool**
config, which intends to specify an action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
