btashton commented on a change in pull request #2696:
URL: https://github.com/apache/incubator-nuttx/pull/2696#discussion_r559010786



##########
File path: arch/sim/Kconfig
##########
@@ -531,16 +531,31 @@ config SIM_QSPIFLASH_PAGESIZE
                "wrap" causing the initial data sent to be overwritten.
                This is consistent with standard SPI FLASH operation.
 
+choice

Review comment:
       I don't think this should be choice as the options are not exclusive.   
I don't see anything in the driver that would prevent you from exposing HCI0 as 
a tty device and HCI1 to the NuttX network stack. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to