v01d commented on a change in pull request #2696: URL: https://github.com/apache/incubator-nuttx/pull/2696#discussion_r558952853
########## File path: arch/sim/Kconfig ########## @@ -531,16 +531,31 @@ config SIM_QSPIFLASH_PAGESIZE "wrap" causing the initial data sent to be overwritten. This is consistent with standard SPI FLASH operation. +choice + prompt "Simulated Prototype of HCI" + default SIM_HCISOCKET + depends on (HOST_LINUX && SIM_WALLTIME) Review comment: this enables something that should not be enabled by default. this choice should be an option that you can choose to turn on or not. simply add one "none" option and make it default. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org